Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer workflow for Drupal 8 #66

Merged
merged 9 commits into from
Aug 23, 2016
Merged

Composer workflow for Drupal 8 #66

merged 9 commits into from
Aug 23, 2016

Conversation

jhedstrom
Copy link
Member

There will be a corresponding PR in GDT.

For Drupal 8, this stubs out a composer.json file that will install Drupal, Drupal Console, and Drush.

@@ -0,0 +1,26 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better if we loaded the Gruntconfig as a JSON object and simply added/removed properties as needed.

@grayside
Copy link
Contributor

As discussed in #68, the existing distro drivers have a mechanism to copy a drushmake file into place. Seems like the distro plugin for D8 should skip the drushMakeFile() operation.

"build/html/modules/contrib/{$name}": ["type:drupal-module"],
"build/html/profiles/contrib/{$name}": ["type:drupal-profile"],
"build/html/themes/contrib/{$name}": ["type:drupal-theme"],
"build/drush/contrib/{$name}": ["type:drupal-drush"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grayside I've updated this so custom drush commands will be found since drush looks both in docroot and one directory up.

@jhedstrom
Copy link
Member Author

Tests are failing because they are explicitly looking for a .make file.

@mike-potter mike-potter added this to the 1.0.0 milestone Aug 15, 2016
@mike-potter
Copy link
Member

Bumping this for Jonathan to look at the failing tests.

@jhedstrom
Copy link
Member Author

Tests should be fixed now.

@grayside
Copy link
Contributor

I think this is good to go. Before tagging a formal release after this we need to do some more end-to-end testing.

@grayside grayside merged commit 941c596 into master Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants