-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer workflow for Drupal 8 #66
Conversation
335666b
to
44906cf
Compare
@@ -0,0 +1,26 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be better if we loaded the Gruntconfig as a JSON object and simply added/removed properties as needed.
As discussed in #68, the existing distro drivers have a mechanism to copy a drushmake file into place. Seems like the distro plugin for D8 should skip the drushMakeFile() operation. |
"build/html/modules/contrib/{$name}": ["type:drupal-module"], | ||
"build/html/profiles/contrib/{$name}": ["type:drupal-profile"], | ||
"build/html/themes/contrib/{$name}": ["type:drupal-theme"], | ||
"build/drush/contrib/{$name}": ["type:drupal-drush"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grayside I've updated this so custom drush commands will be found since drush looks both in docroot and one directory up.
Tests are failing because they are explicitly looking for a |
Bumping this for Jonathan to look at the failing tests. |
2a75207
to
00e932e
Compare
Tests should be fixed now. |
I think this is good to go. Before tagging a formal release after this we need to do some more end-to-end testing. |
There will be a corresponding PR in GDT.
For Drupal 8, this stubs out a
composer.json
file that will install Drupal, Drupal Console, and Drush.