Handle undecodable responses gracefully #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a try-catch block in the data() method to catch `NotDecodableException` when attempting to decode response data. In such cases, decoding will now default to an empty array instead of throwing an unhandled exception. Moreover, clarified method return types in doc comments for `onError`, `throw`, and `throwIf` to reflect the generic `Response<T>` type.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
============================================
- Coverage 85.39% 85.29% -0.10%
- Complexity 326 327 +1
============================================
Files 39 39
Lines 753 755 +2
============================================
+ Hits 643 644 +1
- Misses 110 111 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a try-catch block in the data() method to catch
NotDecodableExceptionwhen attempting to decode response data. In such cases, decoding will now default to an empty array instead of throwing an unhandled exception. Moreover, clarified method return types in doc comments foronError,throw, andthrowIfto reflect the genericResponse<T>type.