Fixed bugs for User #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `UserController` with CRUD operations using MediatR for clean separation of concerns and streamlined handling of user-related actions. - Removed unused `Controllers` folder reference from `MLS.Api.csproj` for project cleanup. - Converted all command and query classes from `abstract` to `concrete` to simplify usage and align with CQRS and Mediator patterns. - Enhanced logging in `CreateArticleCommandHandler.cs` for clearer context in validation errors. - Standardized namespaces and usings across various files for better code organization. - Adjusted project references to ensure correct inter-project dependencies, enhancing the solution's architecture.
Reversed the mapping direction from DTOs to entities across various profiles, enhancing data transformation consistency and integrity. Implemented a condition in update mappings to only use non-null source values, preventing data loss. Removed obsolete entity-to-DTO mappings and cleaned up namespaces for better clarity and organization. This comprehensive refactoring improves the application's data handling between layers, ensuring a more consistent and reliable architecture.
- Integrated `IUserRepository` into `UserController` for enhanced direct repository actions, moving beyond the exclusive use of CQRS with MediatR for user operations. - Updated `UserController.Put` method route to expect user ID in the request body instead of URL. - Removed `PasswordHash` from `UpdateUserDto` and its validation in `UserDtoValidator` to prevent password updates through this DTO, enhancing security. - Fixed incorrect method call in `DeleteUserCommandHandler` by replacing `CreateAsync` with `DeleteAsync` for proper user deletion. - Transitioned `UpdateUserCommand` from abstract to concrete and made `User` property nullable to support partial updates. - Altered mapping profiles to map all properties regardless of nullability, simplifying data update mechanisms and allowing for potential null value overwrites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Classification
This pull request implements new features and code cleanup by introducing the CQRS pattern, enhancing DTO mappings, and improving security practices.
PR Summary
This PR focuses on restructuring the application to support the CQRS pattern, enhancing security by modifying DTOs, and refining AutoMapper configurations for cleaner separation of concerns.
MediatRinUserController.csfor CQRS pattern implementation and CRUD operations.PasswordHashproperty fromUpdateUserDto.csand adjustedUserDtoValidator.csfor improved security.DeleteUserCommandHandler.csby changingCreateAsynctoDeleteAsync.CreateArticleCommandHandler.csto focus on core functionalities.PR Classification
This pull request implements significant architectural enhancements, focusing on API controller refinement, DTO validation and mapping improvements, and aligning the application with CQRS and clean architecture principles through MediatR utilization.
PR Summary
The pull request introduces a new
UserControllerwith CRUD operations following the CQRS pattern, improves DTO mappings, and fixes a critical bug in user deletion. It also streamlines the application's structure by cleaning up project references and modifying command and query classes for direct instantiation.abstracttopublicto facilitate direct instantiation with MediatR handlers.CreateAsyncwithDeleteAsync.PasswordHashproperty and its validation.