This pull request focuses on enhancing code robustness, error handling, and reducing redundancy through the adoption of non-nullable reference types and initialization of properties with default values across various classes and DTOs. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances the robustness of the application by initializing all string properties to `string.Empty`, setting navigation properties to non-nullable states using the null-forgiving operator (`null!`), and initializing collections to new instances across various entities including `Address`, `Article`, `Category`, `Comment`, `Discount`, `Notification`, `Order`, `OrderDetail`, `Payment`, `Product`, `ProductColor`, `ProductImage`, `ProductOption`, `ProductReview`, `ProductTag`, `Shipment`, `ShoppingCart`, `ShoppingCartItem`, `Supplier`, `Supply`, `Tag`, `User`, `WishList`, and `WishListItem`. These changes aim to eliminate `NullReferenceException` errors by ensuring properties and collections are never `null`, thereby simplifying null checks and enhancing code safety. This approach aligns with modern C# practices, leveraging the nullability feature to make the codebase more expressive and safer by making null handling intentions explicit.
This commit represents a significant refactoring effort across the application, focusing on improving the handling of nullable properties, simplifying data transfer objects (DTOs), and enhancing validation logic. Key changes include: - Initialization of string and collection properties in various DTOs to ensure non-null defaults or to explicitly handle null values, enhancing the robustness of data handling. - Simplification of DTO structures by removing unnecessary properties, collections, and usings, aiming for cleaner, more maintainable code. - Introduction of DTO inheritance for a more hierarchical and efficient data model, reducing code duplication and leveraging polymorphism. - Adjustment of validators to reflect DTO changes, removing specific collection validations, and simplifying validation rules to align with the updated DTO properties. - Command and profile mapping updates to initialize properties with default values or mark them explicitly as non-nullable, ensuring data integrity and preventing null value errors. - General cleanup including the removal of unnecessary using directives and the standardization of namespace declarations with curly braces. These changes collectively enhance the application's data handling capabilities, improve maintainability, and align the codebase with current best practices for nullability and DTO management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes aim to improve null safety and streamline data handling in entity and DTO classes by initializing properties with default values and making navigation properties non-nullable. This effort reduces the risk of null reference exceptions and simplifies client-side code.
string.Emptyand collections withnew List<T>()in entity classes likeAddress,Article,Category, etc., to prevent null references.GenericRepositoryto throw aKeyNotFoundExceptionfor better error handling.