Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] update rest endpoint method names to avoid swagger conflict #10

Closed
wants to merge 1 commit into from
Closed

[fix][broker] update rest endpoint method names to avoid swagger conflict #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
broker: update rest endpoint method names to avoid swagger conflict 
Renames two rest endpoint methods which were incorrectly named and cause an ID
conflict in the generated swagger.

This change also removes the gen-swagger.sh script which is no longer used.

Signed-off-by: Paul Gier <[email protected]>
  • Loading branch information
@pgier
pgier committed May 19, 2023
commit de866b7ca39eadaceae67350963694cfb69f87f7
6 changes: 3 additions & 3 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2519,7 +2519,7 @@ public void getMaxTopicsPerNamespace(@Suspended final AsyncResponse asyncRespons
@ApiOperation(value = "Set maxTopicsPerNamespace config on a namespace.")
@ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission"),
@ApiResponse(code = 404, message = "Tenant or namespace doesn't exist"), })
public void setInactiveTopicPolicies(@PathParam("tenant") String tenant,
public void setMaxTopicsPerNamespace(@PathParam("tenant") String tenant,
@PathParam("namespace") String namespace,
@ApiParam(value = "Number of maximum topics for specific namespace",
required = true) int maxTopicsPerNamespace) {
Expand All @@ -2529,10 +2529,10 @@ public void setInactiveTopicPolicies(@PathParam("tenant") String tenant,

@DELETE
@Path("/{tenant}/{namespace}/maxTopicsPerNamespace")
@ApiOperation(value = "Set maxTopicsPerNamespace config on a namespace.")
@ApiOperation(value = "Remove maxTopicsPerNamespace config on a namespace.")
@ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission"),
@ApiResponse(code = 404, message = "Tenant or namespace doesn't exist"), })
public void setInactiveTopicPolicies(@PathParam("tenant") String tenant,
public void removeMaxTopicsPerNamespace(@PathParam("tenant") String tenant,
@PathParam("namespace") String namespace) {
validateNamespaceName(tenant, namespace);
internalRemoveMaxTopicsPerNamespace();
Expand Down
33 changes: 0 additions & 33 deletions src/gen-swagger.sh
View file
Open in desktop

This file was deleted.