Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC:matrix: Streamlined "every XX row/col" example #873

Merged
merged 3 commits into from
Jun 16, 2020
Merged

DOC:matrix: Streamlined "every XX row/col" example #873

merged 3 commits into from
Jun 16, 2020

Conversation

ilayn
Copy link
Member

@ilayn ilayn commented Jun 13, 2020

Continuation of #871

A bit better example via ./list handlers and better colorization thanks to @Mo-Gul's suggestion.

hmenke
hmenke previously approved these changes Jun 14, 2020
View reviewed changes
@pgf-tikz pgf-tikz deleted a comment from ilayn Jun 14, 2020
@Mo-Gul
Copy link
Contributor

Mo-Gul commented Jun 14, 2020

Ups, it seems that I have deleted your comment @ilayn. That was not intended but seemed to happen when I adjusted my suggestions, sorry.

Ok, I adapted my suggestions to use olive for the first column and olive!50 for the striped col style. The picture then looks like

image showing the result after applying my suggestions

Fine with that?

@hmenke
Copy link
Member

hmenke commented Jun 16, 2020

I should have merged this before #872, now there are merge conflicts. Sorry about that. @ilayn Let me know when this is ready to merge, then I'll resolve the conflicts.

@ilayn
Copy link
Member Author

ilayn commented Jun 16, 2020 •
edited
Loading

No problem. I rebased onto master and resolved conflicts. If @Mo-Gul is happy with the colors it should be good to go.

Sorry for the delay. Work is a bit busy these days.

Mo-Gul
Mo-Gul approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@Mo-Gul Mo-Gul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I am correct you have adapted my suggested colors. So of course I am happy :)

@hmenke hmenke merged commit 7e0da7e into pgf-tikz:master Jun 16, 2020
@ilayn ilayn deleted the patch-1 branch June 16, 2020 09:32
@hmenke
Copy link
Member

hmenke commented Jun 17, 2020

@ilayn I am very impressed with the exceptionally high quality of your contributions. Therefore I would like to grant you write access to all repos, given that you are fine with that.

@ilayn
Copy link
Member Author

ilayn commented Jun 17, 2020

Oh my, that's very flattering Henri, much appreciated. I have to ask though, I am really not active in TeX stuff so I'm usually passing by. I feel good when I am useful but are you OK with me being absent most of the time? I mean it is a responsibility that I should honor somehow but daily work + SciPy maintenance is keeping me quite busy.

If you are OK with it sure I'd be grateful but please feel free to decline if that's not what you have in mind. Disagreement is always better than disappointment 😃

@muzimuzhi muzimuzhi mentioned this pull request Sep 22, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmenke hmenke hmenke approved these changes

@Mo-Gul Mo-Gul Mo-Gul approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilayn @Mo-Gul @hmenke