Skip to content

Commit

Permalink
Expand the range of supported setuptools. (#541)
Browse files Browse the repository at this point in the history
We now just exclude the island where setuptools ran a disruptive
de-vendoring experiment.
  • Loading branch information
jsirois authored Aug 21, 2018
1 parent 0a8eee3 commit f125317
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
1 change: 1 addition & 0 deletions pex/testing.py
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,7 @@ def ensure_python_distribution(version):
if not os.path.exists(interpreter_location):
os.environ['PYENV_ROOT'] = pyenv_root
subprocess.check_call([pyenv, 'install', '--keep', version])
subprocess.check_call([pip, 'install', '-U', 'pip'])
subprocess.check_call([pip, 'install', SETUPTOOLS_REQUIREMENT])

python = os.path.join(interpreter_location, 'bin', 'python' + version[0:3])
Expand Down
9 changes: 4 additions & 5 deletions pex/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@

__version__ = '1.4.5'

# NB: If we upgrade to setuptools>=34 pex's bootstrap code in `PEXBuilder` will need an update to
# include the `packaging` package in the `.bootstrap/` code since we use
# `packaging.specifiers.SpecifierSet` - indirectly - through `pkg_resources.Requirement.specifier`.
SETUPTOOLS_REQUIREMENT = 'setuptools>=20.3,<34.0'
# Versions 34.0.0 through 35.0.2 (last pre-36.0.0) de-vendored dependencies which causes problems
# for pex code so we exclude that range.
SETUPTOOLS_REQUIREMENT = 'setuptools>=20.3,<41,!=34.*,!=35.*'

WHEEL_REQUIREMENT = 'wheel>=0.26.0,<0.32.0'
WHEEL_REQUIREMENT = 'wheel>=0.26.0,<0.32'

0 comments on commit f125317

Please sign in to comment.