Taygun Savaş (#135)

* Issue Number : #134 * Issue Number: #134 Fix * Update ValidatorTestCategoryEnum.cs
petrsvihlik · Oct 29, 2021 · c8876da · c8876da
1 parent e20e5ef
commit c8876da
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 7 deletions.
diff --git a/WopiHost.Url.Tests/WopiUrlGeneratorTests.cs b/WopiHost.Url.Tests/WopiUrlGeneratorTests.cs
@@ -82,7 +82,7 @@ public void SettingsArePresent()
             var hostSessionId = Guid.NewGuid().ToString();
             var sessionContext = Guid.NewGuid().ToString();
             var wopiSource = "c:\\doc.docx";
-            var validatorTestCategory = "All";
+            var validatorTestCategory = ValidatorTestCategoryEnum.All;
 
             // Act
             var settings = new WopiUrlSettings()

diff --git a/WopiHost.Url/ValidatorTestCategoryEnum.cs b/WopiHost.Url/ValidatorTestCategoryEnum.cs
@@ -0,0 +1,22 @@
+namespace WopiHost.Url
+{
+    /// <summary>
+    /// This value is used to run the WOPI Validation application in different modes.
+    /// This value can be set to All, OfficeOnline or OfficeNativeClient to activate tests specific to Office Online and Office for iOS.If omitted, the default value is All.
+    /// </summary>
+    public enum ValidatorTestCategoryEnum
+    {
+        /// <summary>
+        /// All: activates all WOPI Validation application tests. 
+        /// </summary>
+        All,
+        /// <summary>
+        /// OfficeOnline: activates all tests necessary for Office Online integration.
+        /// </summary>
+        OfficeOnline,
+        /// <summary>
+        /// OfficeNativeClient: activates all tests necessary for Office for iOS integration.
+        /// </summary>
+        OfficeNativeClient
+    }
+}
diff --git a/WopiHost.Url/WopiHost.Url.csproj b/WopiHost.Url/WopiHost.Url.csproj
@@ -21,8 +21,8 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <None Include="..\LICENSE.txt" Pack="true" PackagePath=""/>
-    <None Include="..\img\logo.png" Pack="true" PackagePath=""/>
+    <None Include="..\LICENSE.txt" Pack="true" PackagePath="" />
+    <None Include="..\img\logo.png" Pack="true" PackagePath="" />
   </ItemGroup>
 
   <PropertyGroup>

diff --git a/WopiHost.Url/WopiUrlSettings.cs b/WopiHost.Url/WopiUrlSettings.cs
@@ -152,17 +152,20 @@ public string WopiSource
         }
 
         /// <summary>
-        /// TODO: convert to enum
         /// This value is used to run the WOPI Validation application in different modes.
         /// This value can be set to All, OfficeOnline or OfficeNativeClient to activate tests specific to Office Online and Office for iOS.If omitted, the default value is All.
         /// All: activates all WOPI Validation application tests.
         /// OfficeOnline: activates all tests necessary for Office Online integration.
         /// OfficeNativeClient: activates all tests necessary for Office for iOS integration.
         /// </summary>
-        public string ValidatorTestCategory
+        public ValidatorTestCategoryEnum ValidatorTestCategory
         {
-            get => this["VALIDATOR_TEST_CATEGORY"];
-            set => this["VALIDATOR_TEST_CATEGORY"] = value;
+            get
+            {
+                Enum.TryParse(this["VALIDATOR_TEST_CATEGORY"], out ValidatorTestCategoryEnum validator);
+                return validator;
+            }
+            set => this["VALIDATOR_TEST_CATEGORY"] = value.ToString();
         }
 
         /// <summary>