Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed jshint complaints (interrupted testing) #540

Closed
wants to merge 2 commits into from
Closed

Fixed jshint complaints (interrupted testing) #540

wants to merge 2 commits into from

Conversation

Artazor
Copy link
Contributor

@Artazor Artazor commented Mar 22, 2015

Fixed line length check failure introduced in 9112e57

@Artazor
Copy link
Contributor Author

Artazor commented Mar 23, 2015

Update: added two commits:

  • 5dccd5b - to enable cancellation testing in browser.
  • 29d9e5f - to make awaitGlobalException browser friendly (process.on and process.off emulated by the browserify was no-op)

@petkaantonov
Copy link
Owner

Thanks, can you rebase this to current 3.0?

@Artazor
Copy link
Contributor Author

Artazor commented Mar 23, 2015

Done!

@Artazor
Copy link
Contributor Author

Artazor commented Mar 24, 2015

Btw, have you checked why the Travis CI is failing - only the last variant (of four) is successful?

@petkaantonov
Copy link
Owner

PR builds don't have access to access tokens for sauce labs and 3.0 builds fail on certain node versions

@petkaantonov
Copy link
Owner

Landed in 0b2a2bb

@snyk-bot snyk-bot mentioned this pull request Sep 27, 2020
Open
@Woodpile37 Woodpile37 mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Artazor @petkaantonov