Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added driver for the WeAct Studio 2.9in EPD (SSD1680) #56

Merged
merged 2 commits into from
Sep 2, 2023

Conversation

EnricoRoss98
Copy link

Added driver, demo and setup-example for the WeAct Studio 2.9in eInk display with an SSD1680 inside

Copy link
Owner

@peterhinch peterhinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I don't understand the need for a specific demo. Is there a problem with the existing 2.9" demos on this display?

Other epaper drivers are in the drivers/epaper directory. I think we should stick to this arrangement.

@EnricoRoss98
Copy link
Author

Ok, I moved the driver inside the folder drivers/epaper/ and removed the demo that I've previously added. In practice there's no need for a new dedicated demo: I wrote that demo for my needs and I thought that it would cost me nothing to add it to the project but you're right, is better to stay as light as possible and avoid clutter so I removed it.

Copy link
Owner

@peterhinch peterhinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@peterhinch peterhinch merged commit 6894c4f into peterhinch:master Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants