Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Return $0.00 if there are no transactions #144

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

LeonhardTissen
Copy link
Contributor

Issue:

  • When there aren't any transactions, the text is incomplete as getMostUsedCurrency() returns null whereas in any other case it returns a string

Before:
image

After:
image

Formatting seen in demo:
image

Copy link

netlify bot commented Jun 1, 2024

Deploy Preview for discordpackage ready!

Name Link
🔨 Latest commit 3d40683
🔍 Latest deploy log https://app.netlify.com/sites/discordpackage/deploys/665b115e7ed49e00087148ca
😎 Deploy Preview https://deploy-preview-144--discordpackage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Lulalaby Lulalaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxwellward maxwellward merged commit c8fa547 into peterhanania:main Nov 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants