Support ranged upgrades #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a simple test that upgrading a single package does indeed only upgrade that one package.
The underlying functionality for this was already present within `pip-tool`s, however `pip-compile-multi` wasn't aware of it and thus made assumptions about the nature of the spec argument which turned out to be false. The fix here is to teach `pip-compile-multi` how to interpret these package specs to extract the names for the places it needs them while still passing the full spaces through to `pip-tools` for the actual upgrade. Fixes peterdemin#392
PeterJCLaw
force-pushed
the
support-ranged-upgrades
branch
from
ff78755 to
f8c3e69
Compare
The issue reported in peterdemin#393 turns out to have also been fixed by the range handling fix in the previous commit. This adds a test which verifies that. Fixes peterdemin#393
peterdemin
approved these changes
May 4, 2023
This also makes the pattern case-insensitive and unicode compatible, matching similar patterns in this project.
This ensures a nicer error message for the user.
peterdemin
approved these changes
May 5, 2023
peterdemin
reviewed
May 5, 2023
| expected_root, | ||
| # Cope with posix style reference data on Windows | ||
| replace_name=str(expected_root).replace(os.path.sep, '/'), | ||
| ) | ||
| actual = _load_tree(actual_root) | ||
|
|
||
| assert actual == expected |
There was a problem hiding this comment.
Path separators in the output are platform-specific too. I think it's safe for testing purposes to normalize all \ to / in the actual output.
peterdemin
reviewed
May 5, 2023
| if not replace_name: | ||
| replace_name = str(root) | ||
| return { | ||
| x.relative_to(root).name: x.read_text().replace(replace_name, 'ROOT').replace('\\', '/') |
There was a problem hiding this comment.
I added path separator normalization ☝🏻
There was a problem hiding this comment.
Oh, right, I missed the separators outside the root 🤦, 👍
|
Thank you! |
|
Released in 2.6.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a generic mechanism for adding test cases based on input files, then uses that to validate the failure mode reported in #392. Finally this applies a fix which then passes the added test.
Fixes #392
This also turns out to have fixed #393, so I've added a test for that too.
Fixes #393