-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration.Debug.ShowStartMarkers support #2612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to add a high level test that will ensure the output is correct. This would probably be a P-test.
3da0dd5
to
858fdbe
Compare
sure, added one in Pester.RSpec.Output.ts.ps1. |
@fflaten do you have some opinion here? I am not against the functionality, but the option feels a little too special in the output tab. In v5 we tried to move away from the super configurable output, and this is slightly bringing that back. |
I agree. I'd prefer a generic ANSI option showing progress like "Test abc running (x/y tests completed)" and potentially more. Not worried about CI noise as long as it's configurable. How do other frameworks solve this (the starting indicator)? |
I'd be happy to move it back to the Debug tab if that's preferred (I originally had it there but moved it per PR feedback). Displaying a separate line for test starting seems to be a common practice or option. For example, with GoogleTest, there's a separate "[ RUN ]" line:
With Boost.Test, there's an option to enable a separate "Entering test case" line:
|
xUnit.net also has a separate "[STARTING]" line in verbose mode:
|
@nohwnd - would you like me to move this option back to the Debug tab? |
The reaction was thanks for providing examples for reference 🙂 I don't have any strong opinions on this. |
Allow displaying an indication when each test starts: [|] Test name...
858fdbe
to
2130ee1
Compare
@nohwnd - I moved this setting back to the Debug tab given the feedback above and for parallelism with Debug.ShowNavigationMarkers. |
Thanks, and sorry for re-designing after you were done with the code. |
/backport to rel/5.x.x |
Started backporting to rel/5.x.x: https://github.com/pester/Pester/actions/runs/13443529197 |
PR Summary
Allow displaying an indication when each test starts:
PR Checklist
(Parity with ShowNavigationMarkers)
fixes #2583