Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branchless luhn-algorithm #93

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Branchless luhn-algorithm #93

merged 2 commits into from
Apr 25, 2023

Conversation

ullenius
Copy link
Contributor

Type of change

  • New feature
  • Bug fix
  • Security patch
  • Documentation update
  • Refactoring

Description

Branchless luhn-algorithm

Increase use of primitives

Related issue

Motivation

Improved performance for luhn-algorithm.

Reduced memory usage (no longer creates unecessary Integer objects that are immediately auto-unboxed into primitive ints).

Checklist

  • I have read the CONTRIBUTING document.
  • I have read and accepted the Code of conduct
  • Tests passes.
  • Style lints passes.
  • Documentation of new public methods exists.

Johannestegner
Johannestegner approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@Johannestegner Johannestegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Johannestegner Johannestegner merged commit 83711c1 into personnummer:master Apr 25, 2023
@ullenius ullenius mentioned this pull request Apr 28, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Johannestegner Johannestegner Johannestegner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ullenius @Johannestegner