Skip to content

Commit

Permalink
2021.2 Patch 5 release
Browse files Browse the repository at this point in the history
  • Loading branch information
skardile-perforce committed Jan 30, 2023
1 parent 79bf5e2 commit a08c41c
Show file tree
Hide file tree
Showing 21 changed files with 984 additions and 609 deletions.
4 changes: 2 additions & 2 deletions LICENSE.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Copyright (c) 2022, Perforce Software, Inc. All rights reserved.
Copyright (c) 2023, Perforce Software, Inc. All rights reserved.

Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
Expand Down Expand Up @@ -40,7 +40,7 @@ this program.

P4/P4API License
-----------------------
Copyright (c) 1995-2022, Perforce Software, Inc.
Copyright (c) 1995-2023, Perforce Software, Inc.
All rights reserved.

Redistribution and use in source and binary forms, with or without
Expand Down
38 changes: 38 additions & 0 deletions RELEASENOTES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,44 @@ Key to symbols used in change notes below.
** -- requires P4API.NET built with new P4API
*** -- requires new p4d server program

--------------------------------------------------------------------------

Bug fixed in 2021.2 Patch 5

#2394629 *
Property 'CommandTimeout' in class 'Connection' is marked as
Obsolete, as it is no longer valid.

--------------------------------------------------------------------------

Bug fixed in 2021.2 Patch 4 (2021.2/2393847) (2023/01/18)

#2390047 (Job #113519) * **
Fixed the issue where AccessViolationException (Attempted to
read or write protected memory) was thrown while using
multi-threaded environment

--------------------------------------------------------------------------

New functionality in 2021.2 Patch 3

#2334385 (Job #111968) * **
Added support for the p4Debug.SetLevel() functionality from C++ API

--------------------------------------------------------------------------

Bugs fixed in 2021.2 Patch 3

#2352032 (Job #112528) * **
Fixed the issue where loading p4bridge.dll was causing invalid
environment for other libraries

--------------------------------------------------------------------------

Bugs fixed in 2021.2 Patch 2

#2350293 (Job #112567) * **
Fixed unnecessary extra login calls, when creating P4Server object.

--------------------------------------------------------------------------

Expand Down
13 changes: 9 additions & 4 deletions p4api.net-unit-test/ConnectionTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1599,6 +1599,8 @@ public void LoginTest2()
Assert.AreEqual(target.Server.State, ServerState.Online);
Assert.AreEqual(target.Status, ConnectionStatus.Connected);

target.getP4Server().SetTicketFile(configuration.TestP4Tickets);

// login as alex/alexei
Credential cred2 = target.Login(pass);
Assert.IsNotNull(cred2);
Expand All @@ -1615,7 +1617,6 @@ public void LoginTest2()
}
finally
{
P4Bridge.ReloadEnviro();
Utilities.RemoveTestServer(p4d, TestDir);
p4d?.Dispose();
}
Expand Down Expand Up @@ -1704,7 +1705,7 @@ public void LoginTestjob080984()
try
{
ticketPath = Environment.ExpandEnvironmentVariables(tpath);

// make sure the ticket file exists
// Create the file, or overwrite if the file exists.
using (FileStream fs = System.IO.File.Create(ticketPath))
Expand Down Expand Up @@ -1750,8 +1751,9 @@ public void LoginTestjob080984()
envVar = target.GetP4EnvironmentVar("P4TICKETS");
Assert.AreEqual(envVar, ticketPath);

// now remove it
target.SetP4EnvironmentVar("P4TICKETS", "");
// now reset it
target.SetP4EnvironmentVar("P4TICKETS", configuration.TestP4Tickets);
target.getP4Server().SetTicketFile(configuration.TestP4Tickets);

// BUG #2) No other way to pass the ticket to the api
// but setting the environment variable through .Net,
Expand Down Expand Up @@ -1897,6 +1899,9 @@ public void LoginTestWithNullClient()
Assert.AreEqual(target.Server.State, ServerState.Online);
Assert.AreEqual(target.Status, ConnectionStatus.Connected);

// use the Test .p4tickets file
target.getP4Server().SetTicketFile(configuration.TestP4Tickets);

// set the connection Client to null
target.Client = null;
Credential cred = target.Login(pass);
Expand Down
Loading

0 comments on commit a08c41c

Please sign in to comment.