Bug 1617828: audit_log_filter_db failures #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix increases timeout for event shot wait to 10 minutes and adds silent query at the end of the event.
|
LGTM |
satya-bodapati
added a commit
to satya-bodapati/percona-server
that referenced
this pull request
Feb 22, 2019
Summary: JIRA: https://jira.percona.com/browse/FB8-52 Reference Patch: facebook/mysql-5.6@80ca845 Reference Patch: facebook/mysql-5.6@0fb428b Patch introduces new variable 'innodb_txlog_init_rate' to limit the IO rate of InnoDB redo log file initialization. Pull Request resolved: facebook/mysql-5.6#931 Reviewed By: lth Differential Revision: D13789095 Pulled By: lth fbshipit-source-id: d572c7b8896
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 23, 2020
Summary: JIRA: https://jira.percona.com/browse/FB8-52 Reference Patch: facebook/mysql-5.6@80ca845 Reference Patch: facebook/mysql-5.6@0fb428b Patch introduces new variable 'innodb_txlog_init_rate' to limit the IO rate of InnoDB redo log file initialization. Pull Request resolved: facebook/mysql-5.6#931 Test Plan: jenkins Testing command: mysqld --datadir=/tmp/log_init --skip-grant-tables --skip-networking --socket=socket --innodb-log-file-size=1G --innodb-txlog-init-rate=[rate] With --innodb-txlog-init-rate=0 (no throttling, 1GB init finished in ~49s) 2015-05-22 16:51:20 4018018 [Note] InnoDB: Setting log file ./ib_logfile101 size to 1024 MB InnoDB: Progress in MB: 100 200 300 400 500 600 700 800 900 1000 2015-05-22 16:52:09 4018018 [Note] InnoDB: Setting log file ./ib_logfile1 size to 1024 MB InnoDB: Progress in MB: 100 200 300 400 500 600 700 800 900 1000 With --innodb-txlog-init-rate=10485760 (10MB/s throttling, 1GB log init finished in ~103s) 2015-05-22 16:55:28 4022136 [Note] InnoDB: Setting log file ./ib_logfile101 size to 1024 MB InnoDB: log file write is throttled at 10MB/s InnoDB: Progress in MB: 100 200 300 400 500 600 700 800 900 1000 2015-05-22 16:57:11 4022136 [Note] InnoDB: Setting log file ./ib_logfile1 size to 1024 MB InnoDB: log file write is throttled at 10MB/s InnoDB: Progress in MB: 100 200 300 400 500 600 700 800 900 1000 Without setting the option (use default. 1GB init finished in ~50s. Note the write is already below 128MB/s, so the throttling didn't have any effect) 2015-05-22 17:18:51 4055898 [Note] InnoDB: Setting log file ./ib_logfile101 size to 1024 MB InnoDB: log file write is throttled at 128MB/s InnoDB: Progress in MB: 100 200 300 400 500 600 700 800 900 1000 2015-05-22 17:19:41 4055898 [Note] InnoDB: Setting log file ./ib_logfile1 size to 1024 MB InnoDB: log file write is throttled at 128MB/s InnoDB: Progress in MB: 100 200 300 400 500 600 700 800 900 1000 Reviewed By: lth Differential Revision: D13789095 Pulled By: lth fbshipit-source-id: 8c94859a695
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 24, 2021
Summary: JIRA: https://jira.percona.com/browse/FB8-52 Reference Patch: facebook/mysql-5.6@80ca845 Reference Patch: facebook/mysql-5.6@0fb428b Patch introduces new variable 'innodb_txlog_init_rate' to limit the IO rate of InnoDB redo log file initialization. Pull Request resolved: facebook/mysql-5.6#931 Test Plan: jenkins Testing command: mysqld --datadir=/tmp/log_init --skip-grant-tables --skip-networking --socket=socket --innodb-log-file-size=1G --innodb-txlog-init-rate=[rate] With --innodb-txlog-init-rate=0 (no throttling, 1GB init finished in ~49s) 2015-05-22 16:51:20 4018018 [Note] InnoDB: Setting log file ./ib_logfile101 size to 1024 MB InnoDB: Progress in MB: 100 200 300 400 500 600 700 800 900 1000 2015-05-22 16:52:09 4018018 [Note] InnoDB: Setting log file ./ib_logfile1 size to 1024 MB InnoDB: Progress in MB: 100 200 300 400 500 600 700 800 900 1000 With --innodb-txlog-init-rate=10485760 (10MB/s throttling, 1GB log init finished in ~103s) 2015-05-22 16:55:28 4022136 [Note] InnoDB: Setting log file ./ib_logfile101 size to 1024 MB InnoDB: log file write is throttled at 10MB/s InnoDB: Progress in MB: 100 200 300 400 500 600 700 800 900 1000 2015-05-22 16:57:11 4022136 [Note] InnoDB: Setting log file ./ib_logfile1 size to 1024 MB InnoDB: log file write is throttled at 10MB/s InnoDB: Progress in MB: 100 200 300 400 500 600 700 800 900 1000 Without setting the option (use default. 1GB init finished in ~50s. Note the write is already below 128MB/s, so the throttling didn't have any effect) 2015-05-22 17:18:51 4055898 [Note] InnoDB: Setting log file ./ib_logfile101 size to 1024 MB InnoDB: log file write is throttled at 128MB/s InnoDB: Progress in MB: 100 200 300 400 500 600 700 800 900 1000 2015-05-22 17:19:41 4055898 [Note] InnoDB: Setting log file ./ib_logfile1 size to 1024 MB InnoDB: log file write is throttled at 128MB/s InnoDB: Progress in MB: 100 200 300 400 500 600 700 800 900 1000 Reviewed By: lth Differential Revision: D13789095 Pulled By: lth fbshipit-source-id: 8c94859a695
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 15, 2021
Summary: JIRA: https://jira.percona.com/browse/FB8-52 Reference Patch: facebook/mysql-5.6@80ca845 Reference Patch: facebook/mysql-5.6@0fb428b Patch introduces new variable 'innodb_txlog_init_rate' to limit the IO rate of InnoDB redo log file initialization. Pull Request resolved: facebook/mysql-5.6#931 Reviewed By: lloyd Differential Revision: D13789095 (facebook/mysql-5.6@48615c4) Pulled By: lth fbshipit-source-id: d667be91978
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
Summary: JIRA: https://jira.percona.com/browse/FB8-52 Reference Patch: facebook/mysql-5.6@80ca845 Reference Patch: facebook/mysql-5.6@0fb428b Patch introduces new variable 'innodb_txlog_init_rate' to limit the IO rate of InnoDB redo log file initialization. Pull Request resolved: facebook/mysql-5.6#931 Reviewed By: lloyd Differential Revision: D13789095 Pulled By: lth
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
Summary: JIRA: https://jira.percona.com/browse/FB8-52 Reference Patch: facebook/mysql-5.6@80ca845 Reference Patch: facebook/mysql-5.6@0fb428b Patch introduces new variable 'innodb_txlog_init_rate' to limit the IO rate of InnoDB redo log file initialization. Pull Request resolved: facebook/mysql-5.6#931 Reviewed By: lloyd Differential Revision: D13789095 Pulled By: lth
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 18, 2022
Summary: JIRA: https://jira.percona.com/browse/FB8-52 Reference Patch: facebook/mysql-5.6@80ca845 Reference Patch: facebook/mysql-5.6@0fb428b Patch introduces new variable 'innodb_txlog_init_rate' to limit the IO rate of InnoDB redo log file initialization. Pull Request resolved: facebook/mysql-5.6#931 Reviewed By: lloyd Differential Revision: D13789095 Pulled By: lth
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Apr 12, 2022
Summary: JIRA: https://jira.percona.com/browse/FB8-52 Reference Patch: facebook/mysql-5.6@80ca845 Reference Patch: facebook/mysql-5.6@0fb428b Patch introduces new variable 'innodb_txlog_init_rate' to limit the IO rate of InnoDB redo log file initialization. Pull Request resolved: facebook/mysql-5.6#931 Reviewed By: lloyd Differential Revision: D13789095 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 15, 2024
Summary: JIRA: https://jira.percona.com/browse/FB8-52 Reference Patch: facebook/mysql-5.6@80ca845 Reference Patch: facebook/mysql-5.6@0fb428b Patch introduces new variable 'innodb_txlog_init_rate' to limit the IO rate of InnoDB redo log file initialization. Pull Request resolved: facebook/mysql-5.6#931 Reviewed By: lloyd Differential Revision: D13789095 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 16, 2024
Summary: JIRA: https://jira.percona.com/browse/FB8-52 Reference Patch: facebook/mysql-5.6@80ca845 Reference Patch: facebook/mysql-5.6@0fb428b Patch introduces new variable 'innodb_txlog_init_rate' to limit the IO rate of InnoDB redo log file initialization. Pull Request resolved: facebook/mysql-5.6#931 Reviewed By: lloyd Differential Revision: D13789095 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 17, 2024
Summary: JIRA: https://jira.percona.com/browse/FB8-52 Reference Patch: facebook/mysql-5.6@80ca845 Reference Patch: facebook/mysql-5.6@0fb428b Patch introduces new variable 'innodb_txlog_init_rate' to limit the IO rate of InnoDB redo log file initialization. Pull Request resolved: facebook/mysql-5.6#931 Reviewed By: lloyd Differential Revision: D13789095 Pulled By: lth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix increases timeout for event shot wait to 10 minutes and adds
silent query at the end of the event.
http://jenkins.percona.com/view/5.7/job/mysql-5.7-param/371/#showFailuresLink