-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PS-5932: Implementing --tokudb-force-recovery=6 to skip reading the logs #3413
Conversation
1 2 | ||
2 4 | ||
3 8 | ||
# restart:--tokudb-force-recovery=6 --read-only --super-read-only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we test the behavior if --tokudb-force-recovery=6 and --read-only --super-read-only is not specified? What happens? If --read-only --super-read-only are not specified and --tokudb-force-recovery=6 is specified, I think we should fail to initialize the plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll add that. (We open the tables in read only mode anyway with force recovery, so my guess would be that we get errors elsewhere in the code)
Once percona/PerconaFT#430 lands, you should also amend this commit to update the git submodule commit pointer. |
One more minor thing, it would be good to see jenkins results of 5.6 and 8.0 with the new FT changes to ensure compatibility even though 5.6 (and 8.0?) will not break due to sharing the changes. |
0635387
to
58c91e0
Compare
Update:
|
0f0ecbe
to
936408c
Compare
This could be useful when the server crashed with a corrupted rollback file, and is unable to start up. Specifying --tokudb--force-recovery=6 --super-read-only should start it up in a read-only, but usable state. Some data may be lost and unrecoverable. Starting the server without the read only option is NOT supported.
936408c
to
f327f3e
Compare
This could be useful when the server crashed with a corrupted rollback file,
and is unable to start up. Specifying --tokudb--force-recovery=6 --super-read-only
should start it up in a read-only, but usable state. Some data may be lost and
unrecoverable.
Starting the server without the read only option is NOT supported.
Additional notes: