Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS-5932: Implementing --tokudb-force-recovery=6 to skip reading the logs #3413

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

dutow
Copy link
Contributor

@dutow dutow commented Sep 5, 2019

This could be useful when the server crashed with a corrupted rollback file,
and is unable to start up. Specifying --tokudb--force-recovery=6 --super-read-only
should start it up in a read-only, but usable state. Some data may be lost and
unrecoverable.

Starting the server without the read only option is NOT supported.

Additional notes:

1 2
2 4
3 8
# restart:--tokudb-force-recovery=6 --read-only --super-read-only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test the behavior if --tokudb-force-recovery=6 and --read-only --super-read-only is not specified? What happens? If --read-only --super-read-only are not specified and --tokudb-force-recovery=6 is specified, I think we should fail to initialize the plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll add that. (We open the tables in read only mode anyway with force recovery, so my guess would be that we get errors elsewhere in the code)

@george-lorch
Copy link
Contributor

Once percona/PerconaFT#430 lands, you should also amend this commit to update the git submodule commit pointer.

@george-lorch
Copy link
Contributor

One more minor thing, it would be good to see jenkins results of 5.6 and 8.0 with the new FT changes to ensure compatibility even though 5.6 (and 8.0?) will not break due to sharing the changes.

@dutow dutow force-pushed the ps-5.7-tokurecov branch 3 times, most recently from 0635387 to 58c91e0 Compare September 11, 2019 10:22
@dutow dutow changed the title WIP PS-5932: Implementing --tokudb-force-recovery=6 to skip reading the logs PS-5932: Implementing --tokudb-force-recovery=6 to skip reading the logs Sep 11, 2019
@dutow
Copy link
Contributor Author

dutow commented Sep 11, 2019

Update:

  • no longer WIP
  • updated submodule
  • added cherry pick reference to 5.6 commit
  • disabled the test for now: it fails when ran together with other tests, I'll fix that later (it works on jenkins when only this test is ran)

@dutow dutow force-pushed the ps-5.7-tokurecov branch 2 times, most recently from 0f0ecbe to 936408c Compare September 11, 2019 10:27
This could be useful when the server crashed with a corrupted rollback file,
and is unable to start up. Specifying --tokudb--force-recovery=6 --super-read-only
should start it up in a read-only, but usable state. Some data may be lost and
unrecoverable.

Starting the server without the read only option is NOT supported.
@dutow dutow merged commit 3297349 into percona:5.7 Sep 11, 2019
@dutow dutow deleted the ps-5.7-tokurecov branch September 11, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants