Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ps-5.7-5797 Correction on release note's release date #3385

Merged
merged 1 commit into from
Sep 11, 2019

Conversation

patrickbirch
Copy link
Contributor

fixed release date to 2019

@patrickbirch patrickbirch requested a review from hrvojem August 21, 2019 13:14
Copy link
Contributor

@dutow dutow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this pull request is based on a wrong parent commit - the file you add here exists for 3 months now, but in this change, it looks like it's freshly reated.

This is also not what the commit message describes: it should be only a date change, not adding a whole file.

Copy link
Contributor

@dutow dutow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please edit the commit message before merging, and mention that this is specific to 5.7, doesn't need any change in 8.0. This will make the next null merge easier.

Fixed release date on 27-30

This change is specific to the 5.7 release notes and does not require any change in 8.0.
@patrickbirch patrickbirch merged commit 8735da1 into percona:5.7 Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants