Ps 5.7 myr 35 #1312
Merged
Ps 5.7 myr 35 #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 23, 2017 15:36
- Our gap lock error implementation (from MYR-15) currently is not taking into
account the current ISO mode. This commit fixes this logic to amend an
additional condition before deciding to error to the client:
&& thd_tx_isolation(thd) >= ISO_REPEATABLE_READ
Therefore, if the ISO is <= READ COMMITTED, the gap lock error will not be
raised in the condition of a gap lock, but as the ISO mode moves any further
north in the consistency scale to REPEATABLE READ or SERIALIZABLE, then the
gap lock error will be raised when conditions are met.
laurynas-biveinis
approved these changes
Jan 24, 2017
|
@georgelorchpercona, only 5.6 has been merged before, I merged this one, please make sure bugs etc are updated |
|
Hm, I specifically did not merge this as the 5.7 release branch for 5.7.17 hasn't been made but the 5.6.35 has, was just trying to keep commits to releases somewhat in sync. It doesn't really matter much I guess. |
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Dec 20, 2023
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Dec 20, 2023
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jan 15, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
inikep
pushed a commit
that referenced
this pull request
Jan 17, 2024
Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jan 17, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jan 17, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 8, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Feb 9, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Feb 9, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Feb 12, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 12, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 12, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 12, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 15, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 15, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 15, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 15, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 15, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 15, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 15, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 15, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 15, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
Apr 29, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
May 13, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
May 24, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
oleksandr-kachan
pushed a commit
to oleksandr-kachan/percona-server
that referenced
this pull request
May 27, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
May 31, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
Jun 5, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
Jun 10, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
Jun 12, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
VarunNagaraju
pushed a commit
to VarunNagaraju/percona-server
that referenced
this pull request
Jun 12, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Jul 25, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Jul 30, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Aug 21, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Aug 28, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Aug 30, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
inikep
pushed a commit
that referenced
this pull request
Sep 23, 2024
Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
inikep
pushed a commit
that referenced
this pull request
Sep 25, 2024
Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Sep 25, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Oct 17, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Oct 17, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
dlenev
pushed a commit
to dlenev/percona-server
that referenced
this pull request
Oct 22, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Oct 28, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
inikep
pushed a commit
that referenced
this pull request
Oct 30, 2024
Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 11, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 14, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 14, 2024
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jan 23, 2025
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jan 23, 2025
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
lukin-oleksiy
pushed a commit
to lukin-oleksiy/percona-server
that referenced
this pull request
Jan 27, 2025
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Jan 27, 2025
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
lukin-oleksiy
pushed a commit
to lukin-oleksiy/percona-server
that referenced
this pull request
Jan 29, 2025
…#1312) Upstream commit ID: facebook/mysql-5.6@38b673f PS-8951: Merge percona-202305 (https://jira.percona.com/browse/PS-8951) Summary: In c3f1703231d7fec34de1479b8913a06cd9c4cd79, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac1760c2451200246c5d7fe3233787053b8 suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself. Pull Request resolved: facebook/mysql-5.6#1312 Differential Revision: D46285384 fbshipit-source-id: 11984e05db5cc61ae69e7cfd4228f01d2ac238e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.