ibc-types: bump prost, tendermint, ibc-proto, ics23 #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the following dependencies:
The bump to the latest tendermint version required bumping prost, which in turns required updates of ibc-proto and ics23 (where I opted for their latest releases, respectively).
The two larger changes are:
core::time::Duration
andprotobuf.google.Duration
are now fallible. I introduced a newtype wrapperCometBftDuration
to restore the previous behavior saturating ati64::MAX
(for seconds) andi32::MAX
(for nanos), respectively.[email protected]
onwardtendermint::abci::EventAttribute
became an enum with variantsV037
andV034
, and introduced the fallible accessorsEventAttribute::key_str
andEventAttribute::value_str
, in addition to the infallibleEventAttribute::key_bytes
andEventAttribute::value_bytes
. This required changes in manyTryFrom<Event>
impls that would previously match on&str
keys and directly move (or parse)String
values. I chose to avoid extra error handling, instead matching on byte-string usingvalue_bytes()
(e.g. nowb"packet_src_channel" => {}
instead of the previous"packet_src_channel" => {}
), and relying onString::from_utf8_lossy
for the values.