Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nikhilbio #282

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Nikhilbio #282

merged 4 commits into from
Sep 26, 2024

Conversation

nruia-penn
Copy link
Contributor

What is the difference between sem joined 2024A, and sem joined 2024F

@Clue88
Copy link
Contributor

Clue88 commented Sep 25, 2024

hey nikhil, there's no such thing as 2024F in our system:

A means spring
B means summer
C means fall

so you'll have to list your semester as 2024C

Clue88
Clue88 requested changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@Clue88 Clue88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@nruia-penn
Copy link
Contributor Author

I updated it to 2024C .

nruia-penn
nruia-penn commented Sep 26, 2024
View reviewed changes
Copy link
Contributor Author

@nruia-penn nruia-penn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing if this will automatically run tests -- didn't work how do I like tell github that I did the requested changes

Clue88
Clue88 requested changes Sep 26, 2024
View reviewed changes
src/json/members/nikhil.json Outdated Show resolved Hide resolved
@Clue88 Clue88 merged commit 4814965 into master Sep 26, 2024
5 checks passed
@Clue88 Clue88 deleted the nikhilbio branch September 26, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clue88 Clue88 Clue88 approved these changes

@danielxue danielxue Awaiting requested review from danielxue

@charisgao charisgao Awaiting requested review from charisgao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nruia-penn @Clue88