Nts pool ke binary #1210
Merged
Nts pool ke binary #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1210 +/- ##
==========================================
- Coverage 85.47% 84.03% -1.45%
==========================================
Files 58 63 +5
Lines 17077 17408 +331
==========================================
+ Hits 14596 14628 +32
- Misses 2481 2780 +299 ☔ View full report in Codecov by Sentry. |
folkertdev
force-pushed
the
nts-pool-ke-binary
branch
from
1e48da4 to
233192c
Compare
davidv1992
previously approved these changes
Nov 16, 2023
nts-pool-ke/src/cli.rs
Outdated
| where | ||
| I: IntoIterator<Item = String>, | ||
| { | ||
| // the first argument is the sudo command - so we can skip it |
There was a problem hiding this comment.
This comment seems incorrect
There was a problem hiding this comment.
hah, that' s incorrect in the original too then
|
Feel free to merge this regardless of the one small nitpick, looks good sofar to me |
davidv1992
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.