-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Key Record support based on TLS client certificates #1196
Conversation
d248da0
to
b6098b7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1196 +/- ##
==========================================
+ Coverage 83.65% 83.81% +0.16%
==========================================
Files 63 63
Lines 17457 17669 +212
==========================================
+ Hits 14604 14810 +206
- Misses 2853 2859 +6 ☔ View full report in Codecov by Sentry. |
e588bbc
to
23947b8
Compare
ea31aa1
to
c194d26
Compare
15495c6
to
6d31331
Compare
There is a bit of churn in some of the commits as test-cases were added and then removed; so I'd recommend squashing this. This PR adds:
Still TODO: SupportedProtocolList support (prefer to do that in a separate PR). |
84fb4f9
to
2162323
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, some minor things that still need a feature flag and one style issue.
2162323
to
8207471
Compare
Note; this does not actually add client TLS certificate to the live server; that requires implementing an own |
8207471
to
cc058e1
Compare
No description provided.