Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using the repository token for release creation #99

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

offbyone
Copy link
Contributor

This eliminates the need for a manually managed GH_TOKEN secret; the only scope needed by autopub[github] is the repo scope, which is covered by contents: write in the workflow

@justinmayer justinmayer merged commit 1889234 into pelican-plugins:main Oct 28, 2023
@justinmayer
Copy link
Contributor

@offbyone: I get the impression this did not function as anticipated: https://github.com/pelican-plugins/photos/actions/runs/6697983473/job/18199065950#step:6:40

For now I will probably publish 1.5.0 to PyPI manually, because as it stands now, this is in a half-released state.

@offbyone
Copy link
Contributor Author

That is very much not what I'd expect!

I'm not 100% sure how to try it out either :/

@justinmayer
Copy link
Contributor

Best way to test it would be to do so in a dummy repository and then push a package to test.pypi.org. I've used that flow when I originally created AutoPub. If you want, I can give you access to the relevant repository/repositories: https://github.com/autopub

@offbyone
Copy link
Contributor Author

offbyone commented Oct 30, 2023

Happy to; I'll experiment in there until it's working.

(Might not get to it til tomorrow night; I'm a bit busy today, if that's okay)

@justinmayer
Copy link
Contributor

No worries. I sent you an invitation to the test repo I've used in the past.

@offbyone
Copy link
Contributor Author

Well, at least I can replicate it in the autopub project, but I am utterly confused as to WTF is happening.

@offbyone
Copy link
Contributor Author

I've submitted a support request on it; hopefully I can figure out why this is happening.

@justinmayer
Copy link
Contributor

justinmayer commented Oct 31, 2023

That's great. Thanks for looking deeper into that. I'm wondering if it has something to do with token format. Maybe the GitHub-release project currently only supports "classic" personal access tokens, and the built-in GITHUB_TOKEN token is… not that? I'm really just grasping at straws, though.

@offbyone
Copy link
Contributor Author

We found the issue: scikit-build/github-release#73

@justinmayer
Copy link
Contributor

@offbyone: While we are waiting for a new githubrelease package containing the above-mentioned fix, I have taken the liberty of forking that project in order to work around a problem I ran into when trying to install the current master branch. I just did a test over in the test repository using that fork+branch (relevant commit: autopub/test-github-ci@2fb9904), and it seems that it works now: https://github.com/autopub/test-github-ci/actions/runs/7757008090/job/21155593033

@offbyone
Copy link
Contributor Author

offbyone commented Feb 2, 2024

I'm in favour of vendoring it, under the circumstances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants