Fixed Icarus Crash Issue #121

[BolverBlitz]

Description

The egg crashed on startup when importing a VC DLL, removing vcrun2019 will stop the game from loading this file and removing winetricks all together makes it start much faster

Checklist for all submissions

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same update/change?
• Have you tested and reviewed your changes with confidence that everything works?
• Did you branch your changes and PR from that branch and not from your master branch?
  • If not, why?:
• You verify that the start command applied does not use a shell script
  • If some script is needed then it is part of a current yolk or a PR to add one
• The egg was exported from the panel

[BolverBlitz]

Please check that, i do not have a pelican panel so i just copyed this in the exported file.

[QuintenQVD0]

You messed up. And wrote the pterodactyl exported egg over the pelican one. Please fix.

[QuintenQVD0]

Do not touch the once you do not have. We will take care about that.

[BolverBlitz]

Do not touch the once you do not have. We will take care about that.

So should i revert the file back to its original state or will you fix it?

[QuintenQVD0]

Yea just revert it.

[gOOvER]

The Egg works fine with vcrun2019, vcrun2022

[BolverBlitz]

The Egg works fine with vcrun2019, vcrun2022

Not on any of my pterodactyl nodes

Edit: Just vcrun2022 works but why install it when it works without that?

028c:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\IPHLPAPI.DLL" at 00006FFFFB6A0000: builtin
028c:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\SETUPAPI.dll" at 00006FFFFBC90000: builtin
028c:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\dwmapi.dll" at 00006FFFF90F0000: builtin
028c:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\jsproxy.dll" at 00006FFFF8F20000: builtin
028c:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\WINHTTP.dll" at 00006FFFF8F90000: builtin
028c:err:module:import_dll Loading library MSVCP140.dll (which is needed by L"Z:\\home\\container\\Icarus\\Binaries\\Win64\\IcarusServer-Win64-Shipping.exe") failed (error c000007b).
028c:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\VCRUNTIME140.dll" at 00006FFFFBEB0000: native
028c:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\VCRUNTIME140_1.dll" at 00006FFFF8F00000: native
028c:err:module:loader_init Importing dlls for L"Z:\\home\\container\\Icarus\\Binaries\\Win64\\IcarusServer-Win64-Shipping.exe" failed, status c0000135
container@pterodactyl~ Server marked as offline...
[Pterodactyl Daemon]: ---------- Detected server process in a crashed state! ----------
[Pterodactyl Daemon]: Exit code: 53
[Pterodactyl Daemon]: Out of memory: false
[Pterodactyl Daemon]: Checking server disk space usage, this could take a few seconds...
[Pterodactyl Daemon]: Updating process configuration files...
[Pterodactyl Daemon]: Ensuring file permissions are set correctly, this could take a few seconds...

[gOOvER]

The Egg works fine with vcrun2019, vcrun2022

Not on any of my pterodactyl nodes

Edit: Just vcrun2022 works but why install it when it works without that?

028c:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\IPHLPAPI.DLL" at 00006FFFFB6A0000: builtin
028c:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\SETUPAPI.dll" at 00006FFFFBC90000: builtin
028c:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\dwmapi.dll" at 00006FFFF90F0000: builtin
028c:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\jsproxy.dll" at 00006FFFF8F20000: builtin
028c:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\WINHTTP.dll" at 00006FFFF8F90000: builtin
028c:err:module:import_dll Loading library MSVCP140.dll (which is needed by L"Z:\\home\\container\\Icarus\\Binaries\\Win64\\IcarusServer-Win64-Shipping.exe") failed (error c000007b).
028c:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\VCRUNTIME140.dll" at 00006FFFFBEB0000: native
028c:trace:loaddll:build_module Loaded L"C:\\windows\\system32\\VCRUNTIME140_1.dll" at 00006FFFF8F00000: native
028c:err:module:loader_init Importing dlls for L"Z:\\home\\container\\Icarus\\Binaries\\Win64\\IcarusServer-Win64-Shipping.exe" failed, status c0000135
container@pterodactyl~ Server marked as offline...
[Pterodactyl Daemon]: ---------- Detected server process in a crashed state! ----------
[Pterodactyl Daemon]: Exit code: 53
[Pterodactyl Daemon]: Out of memory: false
[Pterodactyl Daemon]: Checking server disk space usage, this could take a few seconds...
[Pterodactyl Daemon]: Updating process configuration files...
[Pterodactyl Daemon]: Ensuring file permissions are set correctly, this could take a few seconds...

Check, if the server needs vcruntimes. How you know, that ius not needed? Only , because server starts?

[parkervcp]

I have validated this change works