Replace pelias-mergeable with lodash.merge #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
orangejulius
requested changes
Jan 30, 2018
package.json
Outdated
| @@ -37,7 +37,7 @@ | |||
| "colors": "^1.1.2", | |||
| "elasticsearch": "^13.3.1", | |||
| "joi": "^12.0.0", | |||
| "mergeable": "latest", | |||
| "lodash.merge": "latest", | |||
There was a problem hiding this comment.
Can you change this to whatever the latest version is? That way Greenkeeper will help us detect breaking changes.
There was a problem hiding this comment.
Sure, I'll update the PR to reflect that.
pelias-mergeable is to be deprecated, so replace usage with the functionality provided by lodash. Given we only require a small subset of lodash, add dependency for lodash.merge to avoid pulling in an unnecessarily large dependency.
Echelon9
force-pushed
the
refactor/deprecate-mergeable
branch
from
63e3ffc to
e5318f7
Compare
|
@orangejulius done! Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pelias-mergeable is to be deprecated, so replace usage with the functionality provided by
lodash.Given we only require a small subset of lodash, add dependency for
lodash.mergeto avoid pulling in an unnecessarily large dependency.See further the objective in: https://github.com/pelias/mergeable/issues/5