Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: run workflow on pull_request #151

Merged
merged 1 commit into from
Jun 21, 2022
Merged

actions: run workflow on pull_request #151

merged 1 commit into from
Jun 21, 2022

Conversation

missinglink
Copy link
Member

the github actions workflow doesn't run for developers outside of our org, this change adds pull_request as an additional event which will trigger in various additional contexts.

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows

on: push
on:
push:
pull_request:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, very cool you can specify both here!

Copy link
Member

@orangejulius orangejulius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sounds good.

Copy link
Member

@orangejulius orangejulius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, we need to consider things like npm-publish with this change. You made a similar change in another repo, right?

Lets just double check it all real quick before going forward.

Copy link
Member

@orangejulius orangejulius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks good for real now :)

@missinglink missinglink force-pushed the github-actions branch 2 times, most recently from 748eae9 to d330ef2 Compare June 21, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants