-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actions: run workflow on pull_request #151
Conversation
.github/workflows/ci.yml
Outdated
on: push | ||
on: | ||
push: | ||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, very cool you can specify both here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On second thought, we need to consider things like npm-publish
with this change. You made a similar change in another repo, right?
Lets just double check it all real quick before going forward.
8c99cef
to
1cda7a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, looks good for real now :)
748eae9
to
d330ef2
Compare
d330ef2
to
405d964
Compare
the github actions workflow doesn't run for developers outside of our org, this change adds
pull_request
as an additional event which will trigger in various additional contexts.https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows