Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local modules support with recent r10k #3

Closed
pegasd opened this issue Aug 8, 2019 · 1 comment
Closed

Local modules support with recent r10k #3

pegasd opened this issue Aug 8, 2019 · 1 comment

Comments

@pegasd
Copy link
Owner

pegasd commented Aug 8, 2019

A little bit of background: we use a very old forked version of r10k which did not have local module support at the time.
It was implement in our fork (along with some other patches) and a local module would look like this in Puppetfile:

mod 'my_module', :local

Later on, it was implemented in the upstream version, but the syntax is a little different:

mod 'my_module', local: true

# or (essentially the same thing, but with older Ruby syntax)

mod 'my_module', :local => true

At this point, this gem only recognized the first version and also writes Puppetfiles in that format.

I believe the best way to move forward is to first start supporting both formats while reading, but keep on writing Puppetfile in the old format.
Then release a major version that will start writing Puppetfile in a new format (and maybe the old format as a toggle feature).

pegasd added a commit that referenced this issue Aug 8, 2019
pegasd added a commit that referenced this issue Aug 10, 2019
@pegasd
Copy link
Owner Author

pegasd commented Oct 16, 2019

Version 0.10.0 was released with support for reading both formats of local modules. It still writes Puppetfile in legacy format.

There will no longer be any 0.* releases, bugfixes only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant