Skip to content

Commit

Permalink
fix(browser-bundle): Leaked private functions in the global scope
Browse files Browse the repository at this point in the history
`"outputFormat": "global"` was the missing Parcel setting

Closes #989
  • Loading branch information
jonasgloning committed Aug 8, 2022
1 parent c82c9d0 commit 857d425
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -99,15 +99,14 @@
"files": [
"dist/*"
],
"type": "module",
"sideEffects": [
"lib/global.ts",
"lib/supports.ts"
],
"main": "dist/bundler.cjs",
"module": "dist/bundler.mjs",
"browser-minified": "dist/peerjs.min.cjs",
"browser-unminified": "dist/peerjs.cjs",
"browser-minified": "dist/peerjs.min.js",
"browser-unminified": "dist/peerjs.js",
"types": "dist/types.d.ts",
"engines": {
"node": ">= 10"
Expand All @@ -132,17 +131,17 @@
}
},
"browser-minified": {
"includeNodeModules": true,
"context": "browser",
"outputFormat": "global",
"optimize": true,
"engines": {
"browsers": "cover 99%, not dead"
},
"source": "lib/global.ts"
},
"browser-unminified": {
"includeNodeModules": true,
"context": "browser",
"outputFormat": "global",
"optimize": false,
"engines": {
"browsers": "cover 99%, not dead"
Expand All @@ -154,7 +153,7 @@
"contributors": "git-authors-cli --print=false && prettier --write package.json && git add package.json package-lock.json && git commit -m \"chore(contributors): update and sort contributors list\"",
"check": "tsc --noEmit",
"watch": "parcel watch",
"build": "rm -rf dist && parcel build && cp dist/peerjs.cjs dist/peerjs.js && cp dist/peerjs.min.cjs dist/peerjs.min.js",
"build": "rm -rf dist && parcel build",
"prepublishOnly": "npm run build",
"test": "mocha -r ts-node/register -r jsdom-global/register test/**/*.ts",
"format": "prettier --write .",
Expand Down

0 comments on commit 857d425

Please sign in to comment.