Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on x86_64 Linux #3

Merged
merged 1 commit into from
Feb 22, 2025
Merged

Conversation

mrpenner
Copy link

No description provided.

@Sorixelle
Copy link
Member

Sorixelle commented Feb 21, 2025

What environment are you building in? I've had no troubles building the current master on x86_64-linux (granted, in a Nix stdenv, so things might be a little different there) - would be interested to see if I can repro this failure.

Looking at the referenced commit, I think I get what this change is doing though - probably makes sense.

For the CI failure: just prefix the link with [1]: - footnote links don't count for line length checks.

It was assumed that mesa provides the necessary X11 includes,
but it is not always the case, as it can be configured without x11 support.

See:
[1]: https://gitlab.com/qemu-project/qemu/-/commit/fbd57c754f32804a63295f70f271d1ef128ee590

Signed-off-by: Mark Penner <[email protected]>
@mrpenner
Copy link
Author

What environment are you building in?

OpenSuse Slowroll (uses Tumbleweed packages). Compiler is GCC 14.2.1. I'm not sure what all is relevant, but here's the package info for the Mesa-libEGL-devel package that provides EGLNativeWindowType on my system.

Information for package Mesa-libEGL-devel:
------------------------------------------
Repository     : update-slowroll
Name           : Mesa-libEGL-devel
Version        : 24.3.4-402.1
Arch           : x86_64
Vendor         : openSUSE
Installed Size : 116.9 KiB
Installed      : Yes (automatically)
Status         : up-to-date
Source package : Mesa-24.3.4-402.1.src
Upstream URL   : https://www.mesa3d.org
Summary        : Development files for the EGL API
Description    : 
    This package contains the development environment required for
    compiling programs against EGL native platform graphics interface
    library. EGL provides a platform-agnostic mechanism for creating
    rendering surfaces for use with other graphics libraries, such as
    OpenGL|ES and OpenVG.

    This package provides the development environment for compiling
    programs against the EGL library.

@mrpenner
Copy link
Author

mrpenner commented Feb 22, 2025

Oh actually I suppose the important thing is I'm running Wayland and I see here: https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/include/EGL/eglplatform.h?ref_type=heads#L112 there's some includes added if you're running X11, if I'm reading that right. Are you on X11?

@Sorixelle
Copy link
Member

https://gitlab.freedesktop.org/mesa/mesa/-/blob/main/include/EGL/eglplatform.h?ref_type=heads#L112

That one's a compile time check, so it probably depends on what flags your distribution provides at compile-time for their package builds. Definitely implies that variation is possible though, so this change is probably a good idea.

I've tested it myself and haven't run into any compile or runtime issues - LGTM! Thanks for the PR!

@Sorixelle Sorixelle merged commit fa2a3df into pebble-dev:master Feb 22, 2025
1 check passed
@mrpenner mrpenner deleted the fix-build branch February 22, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants