have k3s use nix-snapshotter
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elpdt852 @RobbieBuxton this PR is ready for review! Thank you 🙇 |
elpdt852
approved these changes
Jan 24, 2024
|
I don't have write access to this repo so please go ahead and merge it for me! Thanks again 🚀 |
|
Awesome, nice work!!! |
Thank you @RobbieBuxton ! Please merge away (I don't have write access here) 🙇 |
I don't either currently, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #102
This PR is simpler than both #108 and #109 which upgraded
k3sto a recent version that supports the--image-service-endpointflag. It turns out we can simply write out the config file fork3sinstead of relying on the new flag.