WIP: app launcher #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potherca
approved these changes
Dec 29, 2020
There was a problem hiding this comment.
My concerns thus far
- It might be wise to add a version for Simply-Edit / Simply-Everything (either in a comment in the file or by changing the file name) to make it easier for future updates
- We might want to minify Simply-*.js as it is effectively vendor code (to discourage edits to it).
- I've not explicitly reviewed the PHP code for security issues, I intend to do a thorough review when this MR leaves WIP status.
Agreed - ideally I would like to grab these from a repo/vendor/thing much like the composer components. Maybe we should move them into js/vendor/simplyedit/ or something similar for now? |
Potherca
approved these changes
Jan 14, 2021
Potherca
approved these changes
Jan 14, 2021
adding solid-auth-fetcher bundle
Potherca
approved these changes
Jan 18, 2021
shouldn't be needed, as php-solid-auth also specifies that version, but somehow composer appears to ignore that and goes for the latest version anyway (which is not compatible with php-solid-auth)
Potherca
approved these changes
Jan 22, 2021
Potherca
approved these changes
Jan 30, 2021
…rk to generalize currently fails to actually put() the file (403 forbidden)
use origin from apps definition use permissions from apps definition add user webId to the permissions fix url for the acl doc.
Potherca
approved these changes
Jan 30, 2021
Potherca
approved these changes
Feb 22, 2021
remove cors headers from files, will handle in webserver config instead
Potherca
approved these changes
Feb 25, 2021
added docker-compose
fix paths in init.sh
Potherca
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.