Add solid-crud tests #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, still seems to be something wrong with how the cookie is passed, I'll look into this: https://travis-ci.com/github/pdsinterop/solid-nextcloud/builds/201245588#L699 |
|
The issue is that although solid-nextcloud passes the webid-provider tests, it does not produce valid responses to solid-auth-fetcher. I added a test for that in v1.2.0 of the webid-provider-tests. Blocked on #26. |
|
The docker image is still uploading but you can see the added test here: |
- add workaround for PUT weirdness in Nextcloud - remove @cors directive because it bumps into CSRF prevention in nextcloud. We'll have to handle our own headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.