race condition

pdoerner · May 23, 2023 · e283bfb · e283bfb
1 parent 859950e
commit e283bfb
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/common/aggregate/persistence_health_signal_aggregator.go b/common/aggregate/persistence_health_signal_aggregator.go
@@ -164,12 +164,17 @@ func (s *PersistenceHealthSignalAggregator[_]) emitMetricsLoop() {
 	for {
 		select {
 		case <-s.emitMetricsTimer.C:
+			s.latencyLock.RLock()
 			for key, avg := range s.latencyAverages {
 				s.metricsHandler.Gauge(metrics.PersistenceAvgLatencyPerShardPerNamespace.GetMetricName()).Record(avg.Average(), key.GetMetricTags()...)
 			}
+			s.latencyLock.RUnlock()
+
+			s.errorLock.RLock()
 			for key, ratio := range s.errorRatios {
 				s.metricsHandler.Gauge(metrics.PersistenceErrPerShardPerNamespace.GetMetricName()).Record(ratio.Average(), key.GetMetricTags()...)
 			}
+			s.errorLock.RUnlock()
 		}
 	}
 }