[Persistence] Remove unused dependencies (temporalio#6398)

## What changed? Removed some unused dependencies. Logger was not used in any of these objects. ## Why? Unused code. ## How did you test it? Compiled and ran existing tests. ## Potential risks N/A ## Documentation N/A ## Is hotfix candidate? No
pdoerner · Aug 13, 2024 · de5c361 · de5c361
1 parent b11df91
commit de5c361
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 30 deletions.
diff --git a/common/persistence/cassandra/execution_store.go b/common/persistence/cassandra/execution_store.go
@@ -28,7 +28,6 @@ import (
 	"context"
 	"time"
 
-	"go.temporal.io/server/common/log"
 	p "go.temporal.io/server/common/persistence"
 	"go.temporal.io/server/common/persistence/nosql/nosqlplugin/cassandra/gocql"
 )
@@ -115,14 +114,11 @@ type (
 
 var _ p.ExecutionStore = (*ExecutionStore)(nil)
 
-func NewExecutionStore(
-	session gocql.Session,
-	logger log.Logger,
-) *ExecutionStore {
+func NewExecutionStore(session gocql.Session) *ExecutionStore {
 	return &ExecutionStore{
-		HistoryStore:          NewHistoryStore(session, logger),
-		MutableStateStore:     NewMutableStateStore(session, logger),
-		MutableStateTaskStore: NewMutableStateTaskStore(session, logger),
+		HistoryStore:          NewHistoryStore(session),
+		MutableStateStore:     NewMutableStateStore(session),
+		MutableStateTaskStore: NewMutableStateTaskStore(session),
 	}
 }
 

diff --git a/common/persistence/cassandra/factory.go b/common/persistence/cassandra/factory.go
@@ -108,7 +108,7 @@ func (f *Factory) NewClusterMetadataStore() (p.ClusterMetadataStore, error) {
 
 // NewExecutionStore returns a new ExecutionStore.
 func (f *Factory) NewExecutionStore() (p.ExecutionStore, error) {
-	return NewExecutionStore(f.session, f.logger), nil
+	return NewExecutionStore(f.session), nil
 }
 
 // NewQueue returns a new queue backed by cassandra

diff --git a/common/persistence/cassandra/history_store.go b/common/persistence/cassandra/history_store.go
@@ -30,7 +30,6 @@ import (
 
 	commonpb "go.temporal.io/api/common/v1"
 	"go.temporal.io/api/serviceerror"
-	"go.temporal.io/server/common/log"
 	p "go.temporal.io/server/common/persistence"
 	"go.temporal.io/server/common/persistence/nosql/nosqlplugin/cassandra/gocql"
 	"go.temporal.io/server/common/primitives"
@@ -70,18 +69,13 @@ const (
 type (
 	HistoryStore struct {
 		Session gocql.Session
-		Logger  log.Logger
 		p.HistoryBranchUtilImpl
 	}
 )
 
-func NewHistoryStore(
-	session gocql.Session,
-	logger log.Logger,
-) *HistoryStore {
+func NewHistoryStore(session gocql.Session) *HistoryStore {
 	return &HistoryStore{
 		Session: session,
-		Logger:  logger,
 	}
 }
 

diff --git a/common/persistence/cassandra/mutable_state_store.go b/common/persistence/cassandra/mutable_state_store.go
@@ -35,7 +35,6 @@ import (
 
 	enumsspb "go.temporal.io/server/api/enums/v1"
 	persistencespb "go.temporal.io/server/api/persistence/v1"
-	"go.temporal.io/server/common/log"
 	p "go.temporal.io/server/common/persistence"
 	"go.temporal.io/server/common/persistence/nosql/nosqlplugin/cassandra/gocql"
 	"go.temporal.io/server/common/persistence/serialization"
@@ -360,17 +359,12 @@ const (
 type (
 	MutableStateStore struct {
 		Session gocql.Session
-		Logger  log.Logger
 	}
 )
 
-func NewMutableStateStore(
-	session gocql.Session,
-	logger log.Logger,
-) *MutableStateStore {
+func NewMutableStateStore(session gocql.Session) *MutableStateStore {
 	return &MutableStateStore{
 		Session: session,
-		Logger:  logger,
 	}
 }
 

diff --git a/common/persistence/cassandra/mutable_state_task_store.go b/common/persistence/cassandra/mutable_state_task_store.go
@@ -31,7 +31,6 @@ import (
 
 	"go.temporal.io/api/serviceerror"
 
-	"go.temporal.io/server/common/log"
 	p "go.temporal.io/server/common/persistence"
 	"go.temporal.io/server/common/persistence/nosql/nosqlplugin/cassandra/gocql"
 	"go.temporal.io/server/common/persistence/serialization"
@@ -189,17 +188,12 @@ const (
 type (
 	MutableStateTaskStore struct {
 		Session gocql.Session
-		Logger  log.Logger
 	}
 )
 
-func NewMutableStateTaskStore(
-	session gocql.Session,
-	logger log.Logger,
-) *MutableStateTaskStore {
+func NewMutableStateTaskStore(session gocql.Session) *MutableStateTaskStore {
 	return &MutableStateTaskStore{
 		Session: session,
-		Logger:  logger,
 	}
 }