forked from temporalio/temporal
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## What changed? <!-- Describe what has changed in this PR --> New freeport implementation; taken from battle-tested Temporal projects. ## Why? <!-- Tell your future self why have you made these changes --> Follow-up to temporalio#6915; making it simpler and more robust. ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> - [x] works on Linux (ie CI) - [x] works on Mac (ie my computer) [First CI run](https://github.com/temporalio/temporal/actions/runs/12269035797/attempts/1?pr=6966), `TestNexusCallbackReplicated` failed with `Error while dialing: dial tcp 127.0.0.1:33279: connect: connection refused`. Looks like there was an unrelated data race (that I've reported to Slack). [Second CI run](https://github.com/temporalio/temporal/actions/runs/12269035797/attempts/2?pr=6966) passed. [Third CI run](https://github.com/temporalio/temporal/actions/runs/12269035797?pr=6966), Versioning suite seems to have [timed out](https://github.com/temporalio/temporal/actions/runs/12269035797/job/34233452135?pr=6966#step:8:966). Unrelated. So it seems to be fine from a random port perspective. ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
- Loading branch information
Showing
10 changed files
with
135 additions
and
140 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| // The MIT License | ||
| // | ||
| // Copyright (c) 2024 Temporal Technologies Inc. All rights reserved. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| package freeport | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "net" | ||
| "runtime" | ||
| ) | ||
|
|
||
| // MustGetFreePort returns a TCP port that is available to listen on, | ||
| // for the given (local) host. | ||
| // | ||
| // This works by binding a new TCP socket on port 0, which requests the OS to | ||
| // allocate a free port. There is no strict guarantee that the port will remain | ||
| // available after this function returns, but it should be safe to assume that | ||
| // a given port will not be allocated again to any process on this machine | ||
| // within a few seconds. | ||
| // | ||
| // On Unix-based systems, binding to the port returned by this function requires | ||
| // setting the `SO_REUSEADDR` socket option (Go already does that by default, | ||
| // but other languages may not); otherwise, the OS may fail with a message such | ||
| // as "address already in use". Windows default behavior is already appropriate | ||
| // in this regard; on that platform, `SO_REUSEADDR` has a different meaning and | ||
| // should not be set (setting it may have unpredictable consequences). | ||
| func MustGetFreePort() int { | ||
| port, err := getFreePort("127.0.0.1") | ||
| if err != nil { | ||
| // try ipv6 | ||
| port, err = getFreePort("[::1]") | ||
| if err != nil { | ||
| panic(fmt.Errorf("failed assigning ephemeral port: %w", err)) | ||
| } | ||
| } | ||
| return port | ||
| } | ||
|
|
||
| func getFreePort(host string) (int, error) { | ||
| l, err := net.Listen("tcp", host+":0") | ||
| if err != nil { | ||
| return 0, fmt.Errorf("failed to assign a free port: %v", err) | ||
| } | ||
| defer l.Close() | ||
| port := l.Addr().(*net.TCPAddr).Port | ||
|
|
||
| // On Linux and some BSD variants, ephemeral ports are randomized, and may | ||
| // consequently repeat within a short time frame after the listening end | ||
| // has been closed. To avoid this, we make a connection to the port, then | ||
| // close that connection from the server's side (this is very important), | ||
| // which puts the connection in TIME_WAIT state for some time (by default, | ||
| // 60s on Linux). While it remains in that state, the OS will not reallocate | ||
| // that port number for bind(:0) syscalls, yet we are not prevented from | ||
| // explicitly binding to it (thanks to SO_REUSEADDR). | ||
| // | ||
| // On macOS and Windows, the above technique is not necessary, as the OS | ||
| // allocates ephemeral ports sequentially, meaning a port number will only | ||
| // be reused after the entire range has been exhausted. Quite the opposite, | ||
| // given that these OSes use a significantly smaller range for ephemeral | ||
| // ports, making an extra connection just to reserve a port might actually | ||
| // be harmful (by hastening ephemeral port exhaustion). | ||
| if runtime.GOOS != "darwin" && runtime.GOOS != "windows" { | ||
| r, err := net.DialTCP("tcp", nil, l.Addr().(*net.TCPAddr)) | ||
| if err != nil { | ||
| return 0, fmt.Errorf("failed to assign a free port: %v", err) | ||
| } | ||
| c, err := l.Accept() | ||
| if err != nil { | ||
| return 0, fmt.Errorf("failed to assign a free port: %v", err) | ||
| } | ||
| // Closing the socket from the server side | ||
| _ = c.Close() | ||
| defer r.Close() | ||
| } | ||
|
|
||
| return port, nil | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.