Skip to content

Commit

Permalink
Remove mutable state dependency on callbacks (temporalio#7057)
Browse files Browse the repository at this point in the history
## What changed?
Remove MutalbleState interface dependency on some other interfaces in
`components/callbacks`

## Why?
1. It is not needed.
2. Preparing mutable state to move into separate folder, with other
interfaces.

## How did you test it?
existing tests
  • Loading branch information
ychebotarev authored Jan 8, 2025
1 parent 31b4354 commit 384e241
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 34 deletions.
3 changes: 0 additions & 3 deletions service/history/workflow/mutable_state.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ import (
"go.temporal.io/server/common/definition"
"go.temporal.io/server/common/namespace"
"go.temporal.io/server/common/persistence"
"go.temporal.io/server/components/callbacks"
"go.temporal.io/server/service/history/historybuilder"
"go.temporal.io/server/service/history/hsm"
"go.temporal.io/server/service/history/tasks"
Expand Down Expand Up @@ -151,8 +150,6 @@ type (
ActivityUpdater func(*persistencespb.ActivityInfo, MutableState) error

MutableState interface {
callbacks.CanGetNexusCompletion
callbacks.CanGetHSMCompletionCallbackArg
AddHistoryEvent(t enumspb.EventType, setAttributes func(*historypb.HistoryEvent)) *historypb.HistoryEvent
LoadHistoryEvent(ctx context.Context, token []byte) (*historypb.HistoryEvent, error)

Expand Down
31 changes: 0 additions & 31 deletions service/history/workflow/mutable_state_mock.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 384e241

Please sign in to comment.