Skip to content

Commit

Permalink
Shivam/add force unload task queue back (temporalio#6620)
Browse files Browse the repository at this point in the history
## What changed?
<!-- Describe what has changed in this PR -->
- Added `ForceUnloadTaskQueue` api back.

## Why?
<!-- Tell your future self why have you made these changes -->
- `ShutdownWorker` relies on this API method and the on-going cloud
deployment uses this API method.
- temporalio#6523 ended up changing the API method definition to
`ForceUnloadTaskQueuePartition` and will soon be going into the next
deployment.
- There could be a chance that due to the rolling deployments, frontend
(aka ShutdownWorker) ends up requiring the old API method but matching
has been updated. To prevent this, until 1.23.0, we should have both the
API methods for a safe backwards compatible deployment.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
- Existing suite of tests.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
None, in fact this will fix any risks.

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
no
  • Loading branch information
Shivs11 authored Oct 8, 2024
1 parent abf9dc4 commit 06a8e35
Show file tree
Hide file tree
Showing 15 changed files with 1,519 additions and 1,115 deletions.
74 changes: 74 additions & 0 deletions api/matchingservice/v1/request_response.go-helpers.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 06a8e35

Please sign in to comment.