Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to sf-based map data #79

Merged
merged 8 commits into from
Jan 15, 2024
Merged

Migrate to sf-based map data #79

merged 8 commits into from
Jan 15, 2024

Conversation

pdil
Copy link
Owner

@pdil pdil commented Jan 15, 2024

  • usmapdata was updated to produce sf-based objects in version 0.2.0.
  • These changes update usmap to make use of these changes by using the temporary as_sf parameter in the usmapdata calls.
    • Once the migration is complete, another update will be released that removes these parameters as the new default behavior will be the sf-based objects.
  • usmap_transform() has also been updated to transform inputs to match the new sf-based map data
  • Updated README examples to use new sf-based data

Notes

  • Plotting the raw data can be done using ggplot2::geom_sf() rather than ggplot2::geom_point().
    • There is no need to supply x and y coordinates to the aesthetic mappings.

resolves #31

@pdil pdil added enhancement A suggestion or feature that improves existing functionality tech Technical issues and pull requests not directly related to usmap functionality labels Jan 15, 2024
@pdil pdil added this to the v0.7.0 milestone Jan 15, 2024
@pdil pdil self-assigned this Jan 15, 2024
@pdil pdil marked this pull request as ready for review January 15, 2024 16:11
@pdil pdil merged commit 11b81f3 into master Jan 15, 2024
8 checks passed
@pdil pdil deleted the feature/sf-usmapdata-migration branch January 15, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A suggestion or feature that improves existing functionality tech Technical issues and pull requests not directly related to usmap functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create an R spatial object rather than a gg object to enhance mapping capacity
1 participant