Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github action for releasing to pypi if git tag is added. #727

Merged
merged 13 commits into from
Mar 19, 2022

Conversation

pietermarsman
Copy link
Member

@pietermarsman pietermarsman commented Mar 15, 2022

Pull request

Make publishing of new release to PyPi easier by adding github action automation.

For pull request, the package is published to test.pypi.org with a version similar to 20220315.232503 (the current date and time).

For version tags, the package is published to test.pypi.org and pypi.org with the version tag (excluding the preceding v) as a version.

Fixes #686

How Has This Been Tested?

Publishing to test PyPi works.

Still need to test if publishing to real PyPi and generating a github release also works.

Checklist

  • I have formatted my code with black.
  • I have added tests that prove my fix is effective or that my feature
    works
  • I have added docstrings to newly created methods and classes
  • I have optimized the code at least one time after creating the initial
    version
  • I have updated the README.md or verified that this
    is not necessary
  • I have updated the readthedocs documentation or
    verified that this is not necessary
  • I have added a concise human-readable description of the change to
    CHANGELOG.md

@pietermarsman pietermarsman requested a review from jstockwin March 15, 2022 22:38
@pietermarsman pietermarsman changed the base branch from develop to master March 19, 2022 16:41
@pietermarsman pietermarsman requested a review from jstockwin March 19, 2022 16:42
Copy link
Member

@jstockwin jstockwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pietermarsman pietermarsman merged commit d89cc35 into master Mar 19, 2022
@pietermarsman pietermarsman deleted the cicd-release branch March 19, 2022 19:46
FantasqueX added a commit to FantasqueX/QualCoder that referenced this pull request Mar 24, 2022
Due to pdfminer/pdfminer.six#727, source code on Github and ditribution on pypi of pdfminer.six has been synchronized. As a result, the package of python-pdfminer in ArchLinux repository has been synchronized with pypi. So we can install python-pdfminer from official repository now.
Beants added a commit to HiTalentAlgorithms/pdfminer.six that referenced this pull request Apr 26, 2022
* commit '1bf3c42b59125f4491d863e1c11dca7ebbe96adc':
  Use charset-normalizer instead of chardet (pdfminer#744)
  Refactor ImageWriter and add method for exporting an image from bytes. (pdfminer#737)
  Log warning and continue gracefully if errors in cmap (pdfminer#731)
  Fix log.debug statement in lzw.py by ensuring that self.table is always set (pdfminer#732)
  Raise KeyError when name in name2unicode is not of type str (pdfminer#733)
  Convert fontname to str if it is bytes in HTMLConverter (pdfminer#734)
  Fix github actions tag regex
  Fix github actions tag regex
  Bump version
  Add github action for releasing to pypi if git tag is added. (pdfminer#727)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New version tagging - 20211012
2 participants