Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Replace PDFPasswordIncorrect with PDFEncryptionWarning #706

Closed

Conversation

paulnawat
Copy link

@paulnawat paulnawat commented Jan 31, 2022

Pull request

Thanks for improving pdfminer.six! Please include the following information to
help us discuss and merge this PR:

  • A description of why this PR is needed. What does it fix? What does it
    improve?

  • A summary of the things that this PR changes.

    • PDFPasswordIncorrect no longer has any reference, when raised, resulting in
handle_action exception occurred. Error string: 'module 'pdfminer.pdfdocument' has no attribute 'PDFPasswordIncorrect''

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Include an example pdf if you have one.

Checklist

  • I have added tests that prove my fix is effective or that my feature
    works
  • I have added docstrings to newly created methods and classes
  • I have optimized the code at least one time after creating the initial
    version
  • I have updated the README.md or verified that this
    is not necessary
  • I have updated the readthedocs documentation or
    verified that this is not necessary
  • I have added a concise human-readable description of the change to
    CHANGELOG.md

@paulnawat
Copy link
Author

paulnawat commented Jan 31, 2022

From looking at the CHANGELOG, should we add/release 20211012 tag?

For more info, 20211012 is also available on pypi ( see https://pypi.org/project/pdfminer.six/)
However, looking at the RELEASE page, it's not released yet.

@pietermarsman
Copy link
Member

Due to travis budgets our ci pipeline hasn't run in a while and that is how this bug crept in.

I prefer the fix in #704, where the exception class is introduced again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants