-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple wrapper to extract text from pdf #330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said on gitter: this will be terribly useful!
I'm sure you are planning on adding it, but I noticed that the test is missing.
I've made some small changes. |
For some reason I a word in that last commit message lol About the docstrings, shouldn't we mention the default values, or is the documentation tool we're using able to infer this from the function signature? Apart from that, I think the tests are the only missing thing before this PR can be merged, right? |
I can also squash them with github during the merge if you want.
The documentation shows the function signature with default values. Example.
Yep. |
TIL about this feature, nice I'll try to get a simple test working today. |
Ok, finally added some simple tests. Travis seems to have failed on python 2.7, and I'm not really sure why. Should I bother with it? |
Hhm, I think we should fix that. I've already spend some time on it but I can't find what's going wrong. |
I left that I'll try to fix the test strings for the new default value for |
I hate python 2 so much, I can't wait to see it dead
Ok, I managed to fix it, the error was due to |
😂 |
Thanks for all the work |
Description
Added a simple wrapper that allows one to easily extract text from a PDF file.
Fixes #327
How Has This Been Tested?
Erh, gotta work on some actual tests for that. Other than that, I've been using this function everywhere in my projects.
Checklist