Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY: Only define dependencies in install_requires #306

Merged
merged 4 commits into from
Oct 20, 2019
Merged

DRY: Only define dependencies in install_requires #306

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3596bb
DRY: Only define dependencies in install_requires
hugovk Oct 19, 2019
e361c78
Add missing comma
hugovk Oct 19, 2019
27f49b7
Add dev extras_require
hugovk Oct 20, 2019
84dc5c7
Add section for dev setup
hugovk Oct 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ python:
- "3.5"
- "3.6"
install:
- pip install six
- pip install pycryptodome
- pip install chardet
- pip install sortedcontainers
- pip install tox-travis
script:
nosetests --nologcapture
- tox
10 changes: 6 additions & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
from setuptools import setup
import sys

import pdfminer as package

requires = ['six', 'pycryptodome', 'sortedcontainers', 'chardet ; python_version > "3.0"']

setup(
name='pdfminer.six',
version=package.__version__,
packages=['pdfminer'],
package_data={'pdfminer': ['cmap/*.pickle.gz']},
install_requires=requires,
install_requires=[
'chardet ; python_version > "3.0"'
'pycryptodome',
'six',
'sortedcontainers',
],
description='PDF parser and analyzer',
long_description=package.__doc__,
license='MIT/X',
Expand Down
6 changes: 1 addition & 5 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,4 @@ envlist = py26,py27,py34,py35,py36
[testenv]
commands = nosetests --nologcapture
deps =
six
pycryptodome
chardet
nose
sortedcontainers
nose