Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdftypes] Fixed python 2 leftovers #267

Closed
wants to merge 3 commits into from
Closed

[pdftypes] Fixed python 2 leftovers #267

wants to merge 3 commits into from

Conversation

igormp
Copy link
Contributor

@igormp igormp commented Jul 15, 2019

Replaced .iteritems() with .items()

0xabu and others added 3 commits February 25, 2019 13:08
name2unicode(): handle hexadecimal literals for unicode glyphs in text extraction

Unicode literals are hex, not decimal (refer: https://github.com/adobe-type-tools/agl-specification). We are still far from conformance with the full spec, but this handles more PDFs seen in the wild.
Replaced `.iteritems()` with `.items()`
@tataganesh tataganesh changed the base branch from master to develop July 15, 2019 17:52
@pietermarsman
Copy link
Member

Could you remove the commits by @oxabu? For example by recreating this PR (and directing it from your develop to pdfminer develop).

About the content of your PR. There are a lot more usages of iteritems(). Could you also replace those?

My editor suggest looking into these files:

  • cmapdb.py
  • pdfdevice.py
  • pdffont.py
  • pdfinterp.py
  • pdfpage.py
  • pdftypes.py

@igormp
Copy link
Contributor Author

igormp commented Jul 17, 2019

Sure thing, let's keep the discussion in the new PR.

@igormp igormp closed this Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants