Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid configuration for mediabox_params in PDFPage class. #1081

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix invalid configuration for mediabox_params in PDFPage class. #1081

wants to merge 2 commits into from

Conversation

pprados
Copy link

@pprados pprados commented Feb 25, 2025

Pull request

With some PDF file, see sample,
annotations.pdf
the code crash with TypeError: 'PDFObjRef' object is not iterable

How Has This Been Tested?

I add a test with this file and run pytest

Checklist

  • I have read CONTRIBUTING.md.
  • I have added a concise human-readable description of the change to CHANGELOG.md.
  • I have tested that this fix is effective or that this feature works.
  • I have added docstrings to newly created methods and classes.
  • I have updated the README.md and the readthedocs documentation. Or verified that this is not necessary.

@pprados pprados mentioned this pull request Feb 25, 2025
Open
@pprados pprados force-pushed the pprados/fix_mediabox branch 3 times, most recently from ca8a2ac to b921c19 Compare February 25, 2025 15:40
@pprados pprados force-pushed the pprados/fix_mediabox branch from b921c19 to 536d18c Compare February 25, 2025 15:44
@pprados pprados marked this pull request as ready for review February 25, 2025 15:59
@pprados pprados mentioned this pull request Feb 25, 2025
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabloCastellano PabloCastellano PabloCastellano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pprados @PabloCastellano