fix(a11y): remove aria-readonly from labels for QField, QCodeol, QDat…

…e, QEditor (backport from Qv2) quasarframework#16705
pdanpdan · Dec 18, 2023 · 58278c2 · 58278c2
1 parent cfa7f06
commit 58278c2
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 21 deletions.
diff --git a/ui/src/components/color/QColor.js b/ui/src/components/color/QColor.js
@@ -195,12 +195,9 @@ export default Vue.extend({
     },
 
     attrs () {
-      if (this.disable === true) {
-        return { 'aria-disabled': 'true' }
-      }
-      if (this.readonly === true) {
-        return { 'aria-readonly': 'true' }
-      }
+      return this.disable === true
+        ? { 'aria-disabled': 'true' }
+        : void 0
     }
   },
 

diff --git a/ui/src/components/date/QDate.js b/ui/src/components/date/QDate.js
@@ -666,12 +666,9 @@ export default Vue.extend({
     },
 
     attrs () {
-      if (this.disable === true) {
-        return { 'aria-disabled': 'true' }
-      }
-      if (this.readonly === true) {
-        return { 'aria-readonly': 'true' }
-      }
+      return this.disable === true
+        ? { 'aria-disabled': 'true' }
+        : void 0
     }
   },
 

diff --git a/ui/src/components/editor/QEditor.js b/ui/src/components/editor/QEditor.js
@@ -269,12 +269,9 @@ export default Vue.extend({
     },
 
     attrs () {
-      if (this.disable === true) {
-        return { 'aria-disabled': 'true' }
-      }
-      if (this.readonly === true) {
-        return { 'aria-readonly': 'true' }
-      }
+      return this.disable === true
+        ? { 'aria-disabled': 'true' }
+        : void 0
     },
 
     onEditor () {

diff --git a/ui/src/components/field/QField.js b/ui/src/components/field/QField.js
@@ -258,9 +258,6 @@ export default Vue.extend({
       if (this.disable === true) {
         attrs['aria-disabled'] = 'true'
       }
-      else if (this.readonly === true) {
-        attrs['aria-readonly'] = 'true'
-      }
 
       return attrs
     }