Reworking the processor implementation. #85
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of, what can become, a complicated original implementation migrating
filebeat processors to it's own defined type. There it's much easier to perform
some value checking before generating the configuration files in the config
dir location.
Orignally processors can only be declared using a class parameter like the following example
class{"filebeat": processors => [ { "drop_fields" => { "params" => {"fields" => ["input_type", "offset"]} } } ] }
Now they can be declared using defined type
filebeat::processor
, or still through $filebeat::processors but with a breaking format. Examples:class{"filebeat": processors => { "my_processor" => { "processor_name" => "drop_fields", "params" => {"fields" => ["input_type", "offset"]} } } }
filebeat::processor{"my_processor": processor_name => "drop_fields", params => {"fields" => ["input_type", "offset"]} }
Have had issues with rake testing on my development environment which I cannot figure out. Travis CI testing may or may not be successful with the new test cases.