Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworking the processor implementation. #85

Merged
merged 5 commits into from
Mar 7, 2017
Merged

Reworking the processor implementation. #85

merged 5 commits into from
Mar 7, 2017

Conversation

corey-hammerton
Copy link
Contributor

Instead of, what can become, a complicated original implementation migrating
filebeat processors to it's own defined type. There it's much easier to perform
some value checking before generating the configuration files in the config
dir location.

Orignally processors can only be declared using a class parameter like the following example

class{"filebeat": processors => [ { "drop_fields" => { "params" => {"fields" => ["input_type", "offset"]} } } ] }

Now they can be declared using defined type filebeat::processor, or still through $filebeat::processors but with a breaking format. Examples:

class{"filebeat": processors => { "my_processor" => { "processor_name" => "drop_fields", "params" => {"fields" => ["input_type", "offset"]} } } }

filebeat::processor{"my_processor": processor_name => "drop_fields", params => {"fields" => ["input_type", "offset"]} }

Have had issues with rake testing on my development environment which I cannot figure out. Travis CI testing may or may not be successful with the new test cases.

Instead of, what can become, a complicated original implementation migrating
filebeat processors to it's own defined type. There it's much easier to perform
some value checking before generating the configuration files in the config
dir location.
@corey-hammerton
Copy link
Contributor Author

This provides a more reliable and permanent fix for #79

@pcfens
Copy link
Owner

pcfens commented Feb 6, 2017

I agree - I haven't had a chance to test this at all yet to be honest (everyone's been on vacation). I'm hoping to get it tested in the next few days and pushed up.

@corey-hammerton
Copy link
Contributor Author

I'll fix the conflict on templates/filebeat5.yml.erb at my earliest convenience.

Conflicts:
	templates/filebeat5.yml.erb
@pcfens
Copy link
Owner

pcfens commented Feb 12, 2017

I'm going to test this out and make sure I understand it (we don't use processors yet), and will hopefully merge this week to get it in for the next release. I put a note in the changelog that a breaking change will be showing up in the next feature release.

Thanks for taking the time on this.

@pcfens pcfens merged commit 1407b09 into pcfens:master Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants