Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow processors to be applied to all inputs, and consolidated common configuration #260

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

jbehrends
Copy link
Contributor

  • Moved processors outside of the main if/else so they can be used for ALL inputs
  • Consolidated all "common configurations" which can be applied to all inputs together.

@pcfens pcfens merged commit 1560c44 into pcfens:master Jun 11, 2020
@pcfens
Copy link
Owner

pcfens commented Jun 11, 2020

Thanks! Before I cut a release on this I just wanted to confirm that it doesn't risk breaking any existing configs by moving this part around (we don't use processors, so I wanted to be sure).

@jbehrends
Copy link
Contributor Author

Sure thing! The logic of IF the processor is even defined is still the same. It's just no longer gated inside the "if @input_type" statement.

@jbehrends
Copy link
Contributor Author

@pcfens Wanted to ping you about the possibility of cutting a release with this change in it.

@pcfens
Copy link
Owner

pcfens commented Jun 18, 2020

I just pushed this as 4.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants