Produce valid processors configuration #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It’s more reliable to convert the processors hash to yaml than iterate over it and produce key value pairs.
|
Thanks - I think we were doing it the iterative way because of weird Ruby behavior that's not shipped with Puppet anymore. I'll try and push a new release to the forge soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great module! I ran into one problem when trying to define processors. It was producing stringified versions of the configuration hashes and arrays instead of valid yaml.
Here's my correction. I'm taking the entire hash and generating the yaml from that.
Thanks!