Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Facebook page plugin #45

Merged
merged 1 commit into from
Jun 11, 2015
Merged

Add new Facebook page plugin #45

merged 1 commit into from
Jun 11, 2015

Conversation

lammertw
Copy link
Contributor

This adds support for the new page plugin: https://developers.facebook.com/docs/plugins/page-plugin/

The like-box is now deprecated by Facebook (in favor of the new page plugin).

@pc035860
Copy link
Owner

Hi @lammertw ,

Thanks for the PR!
I'll merge it when the commented line is ready.

@chanduk040
Copy link

Hi Team,

Thanks for giving support for page plugin. As mentioned I have added the above page plugin settings in angular-easyfb.js and I can able to use the page plugin.

But the Issue is if we try to give data-width="500" it is not getting affected like "post" plugin.
It is applying only 180px width. I have also attached screenshot for your reference.

Below is the HTML I have written:

Could you please help/guide me to fix the width issue?

pageplugin_widthissue

@pc035860 pc035860 merged commit b01a413 into pc035860:master Jun 11, 2015
pc035860 added a commit that referenced this pull request Jun 11, 2015
@chanduk040
Copy link

Hi Team,

Thanks for the reply..Updated the Plugin settings to 'href', 'width', 'height', 'hideCover', 'showFacepile', 'showPosts'..But this even didn't resolve the issue..Could you please check once and provide an example?

@pc035860
Copy link
Owner

Hi @chanduk040 ,

I'm aware of the issue and trying to address it right now.
Just wait for my good news!

@chanduk040
Copy link

Oh Thanks a lot.. Would be waiting for your update..

pc035860 added a commit that referenced this pull request Jun 11, 2015
@pc035860
Copy link
Owner

Page plugin should work fine now in v1.3.0.
Check out the updated example here: http://plnkr.co/edit/1c5cWB?p=preview

@chanduk040
Copy link

Awesome!!! Its working perfectly.. Really thanks a lot for the quick fix..

@chanduk040
Copy link

Hi @pc035860 ,

Unfortunately noticed one issue.. Page plugin width issue is working fine on routing.. But for the initial load, the width issue still occurs..

Providing the plunker url for your reference. I have checked the plunker to load page plugin by default so that you can see the issue..

http://plnkr.co/edit/RuUYWsfeYU67z1j8N8Ay?p=preview

pc035860 added a commit that referenced this pull request Jun 12, 2015
@pc035860
Copy link
Owner

Hey @chanduk040, try 61570d8, spent lots of time and effort on this one.

@chanduk040
Copy link

Hi @pc035860,

Really appreciate your effort & time.. Since you were responding very quickly and providing support for the plugin.. Really thanks for your help..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants